tests: use the snapcraft snap for integration tests
Metadata
Current evaluation
Merged after two approvals. The PR updates integration tests to run against the installed snapcraft snap, aligning with user environments. Despite a reported Go runtime address space conflict in CI, the changes were accepted and merged.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals. The PR updates integration tests to run against the installed snapcraft snap, aligning with user environments. Despite a reported Go runtime address space conflict in CI, the changes were accepted and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaces integration test execution with the installed snapcraft snap to improve security and user parity. Reviewers approved the approach. Despite a reported Go runtime address space conflict during unit tests, the changes were successfully merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to run integration tests against the installed snapcraft snap. Maintainers approved the approach for better user parity and security. A Go runtime address space conflict in unit tests was reported but did not prevent the merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions. | |
| #1542 tests: add integration tests for build snaps | snapcraft | merged | Merged integration tests for build snaps. Approved by two reviewers and passed CI. Two test scenarios omitted due to known bugs. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR removing os_release and repo imports from the snapcraft module in integration tests, replacing them with dedicated modules. Fixes #1982. Approved by two reviewers and merged despite a suggestion to extract shared functionality. | |
| #1394 tests: document the test suites in the snapcraft repo | snapcraft | merged | Test suite documentation added to snapcraft. Approved by two reviewers, the merge updated two files with 160 additions and 33 deletions to clarify test execution. Reviewer feedback was incorporated prior to merging. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #5845 test(spread): test building base and snapd snaps | snapcraft | merged | Merged spread tests for building base and snapd snaps. Despite initial CI failures linked to snapcraft issue #5843, the changes were approved and integrated to maintain build compatibility with mainline snapcraft. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. | |
| #4607 fix(application): support snap/craft environment variables | snapcraft | merged | Merged after three approvals and passing CI. The PR adds snap/craft environment variable support across two files. Initial spread test failures and merge conflicts from a concurrent PR were resolved before final integration. | |
| #1894 tests: allow to overwrite the snapcraft install command | snapcraft | merged | Merged after fixing LXD container environment variable propagation. Adds the SNAPCRAFT_INSTALL_COMMAND variable, enabling the snap store team to override the default snapcraft installation step during integration tests. |