← Back to issue list

pluginhandler: warn about migrated system libraries

View original Github issue

Metadata

Project
snapcraft
Number
#1597
Type
pull request
State
closed
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Closed without merging due to unresolved review feedback and design concerns regarding build-attributes exposure. The pull request was abandoned after requested changes were never addressed.

Suggested action:

No scores available.

Issue body

System libraries from the host where a snap build takes place are brought into the priming area without feedback to the user. Since snapcraft is allowed to build on many systems, even those where a proper base filesystem does not exist, we need to warn users when such an event occurs. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging due to unresolved review feedback and design concerns regarding build-attributes exposure. The pull request was abandoned after requested changes were never addressed.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. The author abandoned the pull request after reconsidering the implementation approach due to concerns about exposing build-attributes.
qwen3.6-35b-a3b-mtp-q6 Closed. The author noted concerns about build-attributes exposure, suggesting the approach was abandoned or superseded.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#989 pluginhandler: add support for disabling system library migration snapcraft merged Merged pull request introducing a build-attributes list with a no-system-libraries option to skip system library migration during the prime step. Renamed from build-options per review and resolves Launchpad bug 1639831.
73%
#1829 pluginhandler: warn the inclusion of libraries from the host snapcraft merged Merged a pull request adding a host library inclusion warning to the pluginhandler. The change modified one file with nine added lines, passed CI checks, and required no reviewer comments.
71%