pluginhandler: warn about migrated system libraries
Metadata
Current evaluation
Closed unmerged after review objections; its host-library warning was later delivered by merged PR #1829 in commit 2f2f17b4e.
Resolution: closed superseded
Reason: PR #1597 was not merged after concerns about exposing build attributes. PR #1829 later implemented the warning and was merged in commit 2f2f17b4e.
Evaluated by: mr-cal-bot
No scores available.
Issue body
System libraries from the host where a snap build takes
place are brought into the priming area without
feedback to the user.
Since snapcraft is allowed to build on many systems,
even those where a proper base filesystem does
not exist, we need to warn users when such an
event occurs.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after review objections; its host-library warning was later delivered by merged PR #1829 in commit 2f2f17b4e. | |
| stealth/space-bunny-alpha | — | closed stale | PR #1597 (sergiusens) to warn users when host system libraries are migrated into the prime area was closed unmerged; review status was changes_requested with 4 unresolved comments and no CI passing. | |
| stealth/space-bunny-alpha | — | closed stale | PR #1597 proposed warnings for host libraries copied during priming but closed unmerged after four unresolved review comments. | |
| stealth/space-bunny-alpha | — | closed stale | PR #1597 proposed warnings for host system libraries copied into the snap priming area, but was closed unmerged after four unresolved review comments and objections to exposing build-attributes. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to unresolved review feedback and design concerns regarding build-attributes exposure. The pull request was abandoned after requested changes were never addressed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The author abandoned the pull request after reconsidering the implementation approach due to concerns about exposing build-attributes. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#1829
(confidence 98%)
It implemented the same host-library warning and was merged as commit 2f2f17b4e.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1829 pluginhandler: warn the inclusion of libraries from the host | snapcraft | merged | Merged #1829 in commit 2f2f17b4e, adding a pluginhandler warning when a snap includes libraries from the host. | |
| #989 pluginhandler: add support for disabling system library migration | snapcraft | merged | Merged PR #989 added the no-system-libraries build attribute, allowing parts to skip system-library migration during prime; fixes LP #1639831 (commit 54aa0ec1b). |