← Back to issue list

pluginhandler: warn the inclusion of libraries from the host

View original Github issue

Metadata

Project
snapcraft
Number
#1829
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged a pull request adding a host library inclusion warning to the pluginhandler. The change modified one file with nine added lines, passed CI checks, and required no reviewer comments.

Suggested action:

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a pull request adding a host library inclusion warning to the pluginhandler. The change modified one file with nine added lines, passed CI checks, and required no reviewer comments.
qwen3.6-35b-a3b-mtp-q6 Merged changes adding a pluginhandler warning when host libraries are included. The pull request passed static and unit tests and was successfully integrated by maintainer sergiusens.
qwen3.6-35b-a3b-mtp-q6 Merged changes adding a warning in the plugin handler when host libraries are included. Submitted by maintainer sergiusens, the update passed all checks and was integrated without discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2337 pluginhandler: library detection instead of injection snapcraft merged Merged. Replaced host binary injection with library detection via base snaps, converting missing library errors to warnings. Approved by reviewer and passed CI checks.
74%
#1597 pluginhandler: warn about migrated system libraries snapcraft closed Closed without merging due to unresolved review feedback and design concerns regarding build-attributes exposure. The pull request was abandoned after requested changes were never addressed.
71%