← Back to issue list

kbuild plugin: if the parts build dir already contains a .config file, use it as the base config

View original Github issue

Metadata

Project
snapcraft
Number
#1606
Type
pull request
State
merged
Author
piso77
Labels
Created
Updated
Closed

Current evaluation

Merged a 4-line update to the kbuild plugin that reuses an existing .config file from the part build directory as the base configuration, resolving bug 1722494. Approved by one reviewer with passing CI checks.

Suggested action:

No scores available.

Issue body

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? https://bugs.launchpad.net/snapcraft/+bug/1722494 - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- If the part build dir comes bundled with a .config file, reuse it as the actual base config

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a 4-line update to the kbuild plugin that reuses an existing .config file from the part build directory as the base configuration, resolving bug 1722494. Approved by one reviewer with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a kbuild plugin update that reuses an existing .config file in the part build directory as the base configuration. This resolves bug #1722494 by preserving pre-existing kernel configurations during the build process.
qwen3.6-35b-a3b-mtp-q6 Merged kbuild plugin update that reuses an existing .config file in the part build directory as the base configuration. Resolves bug #1722494 and passes all tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2202 plugins: kbuild: read configs from source directory instead snapcraft merged Merged a kbuild plugin update to read configuration files from the source directory instead of the top-level directory. This fixes remote git repository builds by preventing local debian overrides. Approved, passed CI, and merged.
71%