← Back to issue list

plugins: kbuild: read configs from source directory instead

View original Github issue

Metadata

Project
snapcraft
Number
#2202
Type
pull request
State
merged
Author
jessesung
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2202 (commit b6327b0e4), making kbuild read kernel configs from the source directory so remote Git trees are handled correctly.

Resolution: closed resolved

Reason: PR #2202 was merged and commit b6327b0e4 changed the kbuild plugin to use the source directory instead of TOPDIR, fixing remote Git builds affected by local debian configs.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Configs should be read from source directory instead of TOPDIR, in order to handle a remote git repo properly. Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2202 (commit b6327b0e4), making kbuild read kernel configs from the source directory so remote Git trees are handled correctly.
stealth/space-bunny-alpha — closed resolved Merged #2202 as commit b6327b0e4, making kbuild read configs from the source directory so remote Git trees are not shadowed by local Debian config files.
stealth/space-bunny-alpha — closed resolved Merged PR #2202 as commit b6327b0e4, making kbuild read kernel configs from the source tree instead of TOPDIR so remote Git builds use their intended configs.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2202 (commit b6327b0e4), changing kbuild to read configs from the source directory, fixing remote Git builds affected by local debian configs.
qwen/qwen3.6-35b-a3b — — Merged a kbuild plugin update to read configuration files from the source directory instead of the top-level directory. This fixes remote git repository builds by preventing local debian overrides. Approved, passed CI, and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Resolves a FileNotFoundError in the kbuild plugin when using remote git sources by reading configuration files from the source directory instead of the top directory. Approved after verifying the fix and passing static tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1786083 kbuild plugin: kconfigfile is modified if kconfigs is supplied snapcraft (launchpad) closed kbuild plugin modified the source tree's kconfigfile when kconfigs were supplied. Fixed by merged PR snapcore/snapcraft#2204 (commit f156050bf), which copies kconfigfile before applying kconfigs; LP #1786083 closed by maintainer ~kyrofa.
71%