← Back to issue list

plugins: kbuild: read configs from source directory instead

View original Github issue

Metadata

Project
snapcraft
Number
#2202
Type
pull request
State
merged
Author
jessesung
Labels
Created
Updated
Closed

Current evaluation

Merged a kbuild plugin update to read configuration files from the source directory instead of the top-level directory. This fixes remote git repository builds by preventing local debian overrides. Approved, passed CI, and merged.

Suggested action:

No scores available.

Issue body

Configs should be read from source directory instead of TOPDIR, in order to handle a remote git repo properly. Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a kbuild plugin update to read configuration files from the source directory instead of the top-level directory. This fixes remote git repository builds by preventing local debian overrides. Approved, passed CI, and merged.
qwen3.6-35b-a3b-mtp-q6 Merged. Resolves a FileNotFoundError in the kbuild plugin when using remote git sources by reading configuration files from the source directory instead of the top directory. Approved after verifying the fix and passing static tests.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixes a kbuild plugin FileNotFoundError when using remote git sources by reading configs from the source directory instead of TOPDIR. Changes passed tests and review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#378 New plugin: kbuild snapcraft merged Merged a new kbuild plugin adding 481 lines across 7 files. Reviewers approved after clarifying prepend/append logic for make oldconfig compatibility and multiple kdefconfig support for Ubuntu kernel builds.
72%
#1606 kbuild plugin: if the parts build dir already contains a .config file, use it as the base config snapcraft merged Merged a 4-line update to the kbuild plugin that reuses an existing .config file from the part build directory as the base configuration, resolving bug 1722494. Approved by one reviewer with passing CI checks.
71%
#2204 kbuild: stop modifying kconfigfile snapcraft merged Merged. The kbuild plugin copies the kconfigfile instead of using hard links, preventing unintended modifications to the source tree when combined with kconfigs. Resolves LP: #1786083.
70%