← Back to issue list

Go plugin creating invalid env

View original Github issue

Metadata

Project
snapcraft
Number
#161
Type
pull request
State
merged
Author
jocave
Labels
—
Created
Updated
Closed

Current evaluation

Merged a fix for the Go plugin generating invalid environment variables during python3 executable wrapping. The change removes unnecessary CGO_LDFLAGS. Approved after reviewer confirmation, with a note to backport to the 1.x branch.

Suggested action: —

No scores available.

Issue body

Possible fix for this bug: https://bugs.launchpad.net/snapcraft/+bug/1524374

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a fix for the Go plugin generating invalid environment variables during python3 executable wrapping. The change removes unnecessary CGO_LDFLAGS. Approved after reviewer confirmation, with a note to backport to the 1.x branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for the Go plugin generating invalid environment variables. Approved despite initial requests for a regression test due to urgency and clear resolution. Updated tests verify proper space handling. Recommended for backport to the 1.x branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the Go plugin generating invalid environment variables during python3 executable wrapping. Resolved a Launchpad bug after initial requests for a regression test. Includes an updated test and requires backporting to 1.x.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#244 Backport to 1.x: Go plugin creating invalid env snapcraft merged Merged a backport of PR #161 to the 1.x branch, resolving a bug where the Go plugin generated an invalid environment. The fix required minimal changes across two files.
78%
#92 go plugin: Use CGO_LDFLAGS when building snapcraft merged Merged an update to the go plugin that applies CGO_LDFLAGS during building, enabling staged libraries from stage-packages to be found. The change passed tests, received approval, and resolved the linked bug.
73%
#1343 go plugin: Cross compile with CGo snapcraft merged Merged to enable cross-compilation for Go plugins when CGo is enabled. Approved by one reviewer, the change updates seven files with 83 additions and 7 deletions to correctly handle CGo flags during cross builds.
71%