← Back to issue list

Go plugin creating invalid env

View original Github issue

Metadata

Project
snapcraft
Number
#161
Type
pull request
State
merged
Author
jocave
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #161 fixed invalid Go plugin environment handling for the python3 wrapper; the change is recorded in commit 62dc469ca.

Resolution: closed resolved

Reason: The Go plugin environment change and regression test landed in commit 62dc469ca. Maintainer @come-maiz explicitly approved merging after confirming the test verified the required spacing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Possible fix for this bug: https://bugs.launchpad.net/snapcraft/+bug/1524374

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #161 fixed invalid Go plugin environment handling for the python3 wrapper; the change is recorded in commit 62dc469ca.
stealth/space-bunny-alpha — closed resolved Fixed the Go plugin’s invalid environment when wrapping python3 by removing unnecessary CGO_LDFLAGS. PR #161 merged in commit 74c81b70d.
qwen/qwen3.6-35b-a3b — — Merged a fix for the Go plugin generating invalid environment variables during python3 executable wrapping. The change removes unnecessary CGO_LDFLAGS. Approved after reviewer confirmation, with a note to backport to the 1.x branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for the Go plugin generating invalid environment variables. Approved despite initial requests for a regression test due to urgency and clear resolution. Updated tests verify proper space handling. Recommended for backport to the 1.x branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#244 Backport to 1.x: Go plugin creating invalid env snapcraft merged Merged PR #244 backported #161 to 1.x, fixing the Go plugin’s invalid environment by removing unnecessary CGO_LDFLAGS.
71%