← Back to issue list

Backport to 1.x: Go plugin creating invalid env

View original Github issue

Metadata

Project
snapcraft
Number
#244
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #244 backported #161 to 1.x, fixing the Go plugin’s invalid environment by removing unnecessary CGO_LDFLAGS.

Resolution: closed resolved

Reason: PR #244 merged into the 1.x branch with the two-file fix from PR #161. The original change was commit 62dc469ca, merged as 74c81b70d, and removes the unnecessary CGO_LDFLAGS that made the generated environment invalid.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #161 to 1.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #244 backported #161 to 1.x, fixing the Go plugin’s invalid environment by removing unnecessary CGO_LDFLAGS.
stealth/space-bunny-alpha — closed resolved Merged PR #244 backported #161 to 1.x, fixing the Go plugin’s invalid environment by removing unnecessary CGO_LDFLAGS when wrapping python3.
stealth/space-bunny-alpha — closed resolved Merged into 1.x, backporting #161 to fix the Go plugin’s invalid environment by removing an unnecessary CGO_LDFLAGS wrapper for python3.
stealth/space-bunny-alpha — closed resolved Merged PR #244 backported #161 to 1.x, fixing the Go plugin's invalid environment by removing unnecessary CGO_LDFLAGS.
stealth/space-bunny-alpha — closed resolved Merged PR #244 backported #161 to 1.x, fixing invalid environment generation in the Go plugin with changes to two files.
qwen/qwen3.6-35b-a3b — — Merged a backport of PR #161 to the 1.x branch, resolving a bug where the Go plugin generated an invalid environment. The fix required minimal changes across two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged to the 1.x branch as a backport of #161, fixing the Go plugin's invalid environment variable generation.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#161 Go plugin creating invalid env snapcraft merged Merged PR #161 fixed invalid Go plugin environment handling for the python3 wrapper; the change is recorded in commit 62dc469ca.
71%
#3286 [legacy backport] v1 plugins: lock godep's dependencies snapcraft merged Merged as a legacy backport of #3285, pinning v1 plugin godeps dependencies to avoid newer go-toml releases breaking builds on Go older than 1.10.
70%