snap: patch patchelf on riscv64 (CRAFT-566)
Metadata
Current evaluation
Merged to master. Conditionally applies patchelf patches on riscv64 to prevent breaking other architectures. Approved by one reviewer, passed CI, and added 104 lines across three files without impacting test coverage.
Suggested action: —
No scores available.
Issue body
Conditionally patch on riscv64 to reduce the risk of breaking
currently working architectures.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
-------
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to master. Conditionally applies patchelf patches on riscv64 to prevent breaking other architectures. Approved by one reviewer, passed CI, and added 104 lines across three files without impacting test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a conditional patchelf patch restricted to riscv64 to prevent regressions on other architectures. Successfully integrated into master with no coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Conditionally applies the patchelf patch exclusively on riscv64 to avoid breaking other architectures. No coverage impact. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3589 snap: correct patch apply for patchelf | snapcraft | merged | Merged a two-line fix correcting patch application for patchelf. Approved by a reviewer, passed CI, and merged to master. An unrelated test failure was noted but disregarded to proceed. | |
| #3841 elf: add elf file patcher | snapcraft | merged | Merged an ELF file patcher using patchelf, ported from Snapcraft 6.x. Approved by one reviewer, passed CI checks, and increased test coverage by 0.26%. Resolves CRAFT-1191. | |
| #2528 packaging: use our patchelf branch | snapcraft | merged | Merged into master to fix s390x build failures by switching patchelf to a custom branch with a failing test disabled. The one-line change was approved, passed CI, and integrated. | |
| #2081 elf: patch everything instead of a subset of elf files | snapcraft | merged | Merged a pull request that restores Snapcraft 2.39 behavior by patching all ELF files instead of a subset, reverting a prior change. Approved and passed CI. | |
| #2531 snap: revert to patchelf 0.9 with local patches | snapcraft | merged | Merged a revert to patchelf 0.9 with local patches after version 0.10 generated unreliable binaries on i386, ppc64el, and s390x. The change restores build stability pending upstream fixes. | |
| #1967 project_loader: improve the logic to install patchelf as a build tool | snapcraft | merged | Merged changes improving patchelf installation logic by excluding it on xenial/armhf and xenial/s390x due to broken builds. Users must provide it manually or use the build-snap. Approved and merged after clarifying error handling and architecture exclusions. | |
| #4639 feat: enable patchelf for core24 | snapcraft | merged | Enabled patchelf for core24. Merged after approval from two reviewers and passing CI checks. The change updates six files (+75/-9 lines) with full test coverage on modified code. |