← Back to issue list

Change file migrations such that files move from stage to prime rather than coming from the part each time

View original Github issue

Metadata

Project
snapcraft
Number
#1670
Type
issue
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Closed as obsolete after stage-filter inheritance into prime eliminated the need for stage-to-prime migration redesign; hard-link concerns were deferred to a separate bug.

Resolution: closed stale

Reason: On 2018-03-26, maintainer sergiusens closed the issue as no longer needed after discussion of LP #1537850 and stage-filter inheritance into prime. No redesign was implemented; the hard-link concern was explicitly moved to a separate bug.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Estimate: 1 week We currently have three scriptlets that cover the build step only: prepare, build, and install. We want scriptlets around all lifecycle steps: pull, build, stage, and prime. Note that introducing an install step is not part of this roadmap. There are some complications here that I want to point out. The stage and prime steps are completely handled by the core right now. As soon as we change that and provide the ability to override them, we must account for the possibility that files in stage will be changed from what they were in install, etc. Which means the stage dir must flow to the prime dir, which it does not do today (the file list is retrieved from stage, but the files themselves come from the parts’ install dirs). Note that the stanzas for pull and build can be completed without such a redesign.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed as obsolete after stage-filter inheritance into prime eliminated the need for stage-to-prime migration redesign; hard-link concerns were deferred to a separate bug.
stealth/space-bunny-alpha — closed not a bug Closed as obsolete: stage-to-prime migration redesign was unnecessary after the stage filter was inherited into prime. Hard-link concerns were split into a separate bug.
qwen/qwen3.6-35b-a3b — — Closed as obsolete. The stage-to-prime migration redesign is unnecessary since the stage filter now inherits to prime. Maintainer closed the issue and recommended filing a separate bug for hard link concerns.
qwen/qwen3.6-35b-a3b — — Closed as no longer needed. The proposed file migration redesign became unnecessary after the stage filter was inherited into the prime filter. The maintainer closed the issue and recommended filing a separate bug for hard link concerns.
qwen/qwen3.6-35b-a3b — — Closed as obsolete. Existing stage-to-prime filter inheritance already handles file migration correctly, eliminating the need for the proposed redesign. A separate issue was recommended to address hard link usage.
qwen3.6-35b-a3b-mtp-q6 — — Closed as no longer needed. The stage filter now inherits into the prime filter, eliminating the need for a migration redesign. Maintainer closed the issue and suggested tracking hard link concerns separately.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#304 migration: support Permissions when migrating files craft-parts merged PR #304 was merged, preserving part permissions when migrating files from stage to prime and forwarding them to link_or_copy(); commit 8e87ebf2.
74%
#236 Always migrate files, even if they already exist. snapcraft merged Merged PR #236 in commit a9777ce5c, making hard-link migration replace existing staged files so files produced by parts take precedence over stage-package .deb files.
70%