← Back to issue list

Always migrate files, even if they already exist.

View original Github issue

Metadata

Project
snapcraft
Number
#236
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #236 in commit a9777ce5c, making hard-link migration replace existing staged files so files produced by parts take precedence over stage-package .deb files.

Resolution: closed resolved

Reason: PR #236 was merged into main via merge commit 11b79f1db. Its implementation overwrites existing staged files during hard-link migration, preventing stage packages from taking precedence over part-produced files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This prevents files contained in a stage-package .deb from taking precedence over files of the same name produced in the part. The migration is done via hard linking, which means this doesn't add any noticeable delay. LP: [#1534800](https://bugs.launchpad.net/snapcraft/+bug/1534800)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #236 in commit a9777ce5c, making hard-link migration replace existing staged files so files produced by parts take precedence over stage-package .deb files.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#236 via a9777ce5c; hard-link migration now replaces existing staged files so part-produced files take precedence over stage-package .deb files.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#236 via a9777ce5c: hard-link migration now replaces existing staged files, preventing stage-package .deb files from overriding files produced by parts.
stealth/space-bunny-alpha — closed resolved Merged PR #236 (11b79f1db), making stage-package files replace existing part files via hard links, fixing LP #1534800.
qwen/qwen3.6-35b-a3b — — Merged. Always migrates files during staging, even if they exist, preventing stage-package .deb files from overriding part-produced files. Uses hard linking for performance. A CI file-existence error was resolved before approval and merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that always migrates files during staging, even if they already exist, using hard links to prevent stage-package .deb files from overriding part-produced files. Resolved test coverage and a Travis CI file-existence error before approval.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1670 Change file migrations such that files move from stage to prime rather than coming from the part each time snapcraft closed Closed as obsolete after stage-filter inheritance into prime eliminated the need for stage-to-prime migration redesign; hard-link concerns were deferred to a separate bug.
70%