← Back to issue list

Support strings in grammar

View original Github issue

Metadata

Project
snapcraft
Number
#1686
Type
issue
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

String grammar support landed in merged PR #1817 (574cd766d), enabling grammar-powered source fields and resolving the original request.

Resolution: closed resolved

Reason: Although initially closed as unnecessary when source support proved simple, PR #1817 later merged commit 574cd766d, adding generic string grammar processing for source fields and resolving #1686.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Estimate: 1 week Snapcraft currently has a grammar that allows for behavior to change based on, for example, the host architecture. The use of this grammar is slowly making its way across the snapcraft.yaml. Currently the only items supported are lists (e.g. stage-packages and build-packages). Adding support for strings is required to support further expansion (e.g. making the source key grammar-powered).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved String grammar support landed in merged PR #1817 (574cd766d), enabling grammar-powered source fields and resolving the original request.
stealth/space-bunny-alpha — closed resolved Closed as not needed, but string grammar support was later delivered by merged PR #1817 (commit 574cd766d, 'grammar: support grammar-powered source'), which added generic string processing and enabled grammar on source, resolving #1686 and #1687.
stealth/space-bunny-alpha — closed resolved Merged PR #1817 (574cd766d) ultimately added string grammar support, starting with source fields, resolving #1686 despite its earlier closure as unnecessary.
qwen/qwen3.6-35b-a3b — — Closed without implementation. Maintainer determined the requested string grammar support was unnecessary, as the underlying requirement was resolved via a simpler change to support sources directly. Feature effectively abandoned.
qwen/qwen3.6-35b-a3b — — Closed as unnecessary. The maintainer determined the grammar change was simple enough to implement directly for sources, resolving the requirement without adding explicit string support to the grammar.
qwen/qwen3.6-35b-a3b — — Superseded by a direct implementation. The maintainer added string grammar support inline to enable source key expansion, deeming the separate request unnecessary. Architecture-based package filtering documentation was provided.
qwen3.6-35b-a3b-mtp-q6 — — Closed as unnecessary. The maintainer implemented a simpler change to support grammar-powered sources, rendering the requested string grammar expansion redundant. Architecture-based package selection remains documented.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#1817 (confidence 100%)

    Merged PR #1817 added grammar-powered source support in commit 574cd766d.

Related issues

Issue Project State Summary Similarity
#1817 grammar: support strings snapcraft merged Merged PR #1817 in commit 574cd766d, adding generic grammar processing for string values and enabling it for source, resolving #1686 and #1687.
83%
#1687 Make source grammar-powered snapcraft closed Merged PR #1817 added grammar support for strings and made source grammar-powered in commit 574cd766d, resolving #1687.
75%