grammar: support strings
Metadata
Current evaluation
Merged PR #1817 in commit 574cd766d, adding generic grammar processing for string values and enabling it for source, resolving #1686 and #1687.
Resolution: closed resolved
Reason: PR #1817 was merged as commit 574cd766d. It implemented grammar-powered string processing for source and closed #1686; maintainer comments also confirmed it solved #1687.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
This adds generic support for processing grammar of string values. `source` is the first property to support it, although adding more should be just a matter of updating the schema.
Closes: #1686
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1817 in commit 574cd766d, adding generic grammar processing for string values and enabling it for source, resolving #1686 and #1687. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1817 (commit 574cd766d, 'grammar: support grammar-powered source') by kalikiana adds generic string grammar support, starting with `source`, closing #1686 and #1687. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1817 (commit 574cd766d), adding generic string grammar support starting with source and resolving #1686 and #1687. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI checks. Implements generic support for processing grammar of string values, starting with the source property. Closes issues #1686 and #1687. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged implementation adding generic grammar processing for string values, initially applied to the source property. Closes issues #1686 and #1687. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft#1686
(confidence 100%)
PR #1817 explicitly states that it closes the string-grammar support issue.
-
Likely Fixed By:
snapcraft#1687
(confidence 100%)
A maintainer review comment confirmed that PR #1817 solves the source grammar issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1686 Support strings in grammar | snapcraft | closed | String grammar support landed in merged PR #1817 (574cd766d), enabling grammar-powered source fields and resolving the original request. | |
| #1687 Make source grammar-powered | snapcraft | closed | Merged PR #1817 added grammar support for strings and made source grammar-powered in commit 574cd766d, resolving #1687. | |
| #3652 parts: support for grammar parsing | snapcraft | merged | Merged #3652 via commit cfbe60ac4 (merge 7708b7261), adding Craft Grammar parsing for part source, package, environment, and snap fields. |