← Back to issue list

grammar: support strings

View original Github issue

Metadata

Project
snapcraft
Number
#1817
Type
pull request
State
merged
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Merged following two approvals and passing CI checks. Implements generic support for processing grammar of string values, starting with the source property. Closes issues #1686 and #1687.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This adds generic support for processing grammar of string values. `source` is the first property to support it, although adding more should be just a matter of updating the schema. Closes: #1686

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged following two approvals and passing CI checks. Implements generic support for processing grammar of string values, starting with the source property. Closes issues #1686 and #1687.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation adding generic grammar processing for string values, initially applied to the source property. Closes issues #1686 and #1687.
qwen3.6-35b-a3b-mtp-q6 — — Merged change adding generic grammar support for string values, initially applied to the source property. Resolves issues #1686 and #1687.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#203 feat: support 'for' statements imagecraft merged Merged after adding 'for' statement support to the advanced grammar. Approved by two reviewers, passed all CI checks, and resolves #201. Changes affect 10 files.
72%