tests: use the common base handler on the fake snapd server
Metadata
Current evaluation
Merged PR #1724 in commit af78689eb, switching the fake snapd server to the common base handler to prevent debug messages from leaking into stdout assertions.
Resolution: closed resolved
Reason: The pull request was merged with approval and no unresolved review comments. Commit af78689eb contains the handler change described in the PR.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Our base handler makes sure that the server doesn't print debug messages to stdout. This messages can leak into other tests that are checking stdout.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1724 in commit af78689eb, switching the fake snapd server to the common base handler to prevent debug messages from leaking into stdout assertions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1724 (commit af78689eb) made the fake snapd server use the common base handler, preventing debug output from leaking into tests that check stdout. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the fake snapd server test handler to prevent debug output from leaking into stdout and interfering with other tests. Approved, passed CI, and applied with a minimal three-line change. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to use a common base handler for the fake snapd server in tests, preventing debug output from leaking into stdout and interfering with other tests. The change passed static and unit checks before merging. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft@af78689eb
(confidence 100%)
This is the resolving commit recorded for the pull request.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1569 tests: refactor the fake snapd to not hardcode values | snapcraft | merged | Merged PR #1569 as commit cf2a0bf0a, refactoring fake snapd tests to remove hardcoded values; it was a required follow-up to #1567. | |
| #46 tests: add fake snapd fixture | craft-parts | merged | Merged PR #46 as 64fdf574 (feature commit 9db65074), adding a 212-line fake snapd fixture for testing snap package handling in craft-parts.packages. |