← Back to issue list

tests: use the common base handler on the fake snapd server

View original Github issue

Metadata

Project
snapcraft
Number
#1724
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged updates to the fake snapd server test handler to prevent debug output from leaking into stdout and interfering with other tests. Approved, passed CI, and applied with a minimal three-line change.

Suggested action:

No scores available.

Issue body

Our base handler makes sure that the server doesn't print debug messages to stdout. This messages can leak into other tests that are checking stdout. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged updates to the fake snapd server test handler to prevent debug output from leaking into stdout and interfering with other tests. Approved, passed CI, and applied with a minimal three-line change.
qwen3.6-35b-a3b-mtp-q6 Merged updates to use a common base handler for the fake snapd server in tests, preventing debug output from leaking into stdout and interfering with other tests. The change passed static and unit checks before merging.
qwen3.6-35b-a3b-mtp-q6 Merged. Updates fake snapd server tests to use a common base handler, preventing debug messages from leaking into stdout and interfering with other tests. The change passed static and unit tests and was accepted.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1569 tests: refactor the fake snapd to not hardcode values snapcraft merged Merged PR refactoring fake snapd tests to remove hardcoded values. Approved by two reviewers, CI passed. Six files changed with 238 additions and 126 deletions. Requires PR #1567.
76%
#1799 tests: update the registered snap fake snapcraft merged Merged following approval by one reviewer. Updated the registered snap fake in tests, changing 2 files with 4 additions and 4 deletions.
73%
#46 tests: add fake snapd fixture craft-parts merged Merged after two approvals and passing CI. Introduces a fake snapd fixture to test snap package handling in craft-parts.packages. Adds 212 lines across two files. Windows compatibility limitations were noted for separate follow-up.
72%
#4755 tests: fix devel base snap test snapcraft merged Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change.
72%