tests: refactor the fake snapd to not hardcode values
Metadata
Current evaluation
Merged PR #1569 as commit cf2a0bf0a, refactoring fake snapd tests to remove hardcoded values; it was a required follow-up to #1567.
Resolution: closed resolved
Reason: PR #1569 merged with two approvals and no unresolved review comments, landing as commit cf2a0bf0a. The refactor followed and completed the test work required by merged PR #1567.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Requires #1567
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1569 as commit cf2a0bf0a, refactoring fake snapd tests to remove hardcoded values; it was a required follow-up to #1567. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1569 as commit cf2a0bf0a, removing hardcoded values from fake-snapd tests after two approvals and no unresolved review comments. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/snapcraft#1569 as commit cf2a0bf0a, refactoring the fake snapd test helper to remove hardcoded values after two approvals. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR refactoring fake snapd tests to remove hardcoded values. Approved by two reviewers, CI passed. Six files changed with 238 additions and 126 deletions. Requires PR #1567. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a pull request refactoring fake snapd tests to remove hardcoded values. The change depends on PR #1567 and passes all static and unit tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1567
(confidence 99%)
PR #1569 explicitly required #1567, which introduced recording of installed snaps.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #46 tests: add fake snapd fixture | craft-parts | merged | Merged PR #46 as 64fdf574 (feature commit 9db65074), adding a 212-line fake snapd fixture for testing snap package handling in craft-parts.packages. | |
| #1724 tests: use the common base handler on the fake snapd server | snapcraft | merged | Merged PR #1724 in commit af78689eb, switching the fake snapd server to the common base handler to prevent debug messages from leaking into stdout assertions. | |
| #1799 tests: update the registered snap fake | snapcraft | merged | Merged #1799, a test-only update to the registered snap fake changing four lines across two files; it received one approval with no unresolved comments. | |
| #380 tests: refactor verify_network and DEFAULT_FAKE_CMD usage | craft-providers | merged | PR #380 by mr-cal merged into main as commit 695a7cc, a test-only refactor of verify_network/DEFAULT_FAKE_CMD usage (+41/-96, 5 files) preparing for #184 (Use `snap refresh --hold`, fixed in 09ef06f). | |
| #2352 tests: use valid snap names in unit tests | snapcraft | merged | Merged PR #2352 (commit b8c0a4fbf) changed snap names used in unit tests so they pass snap pack --check-skeleton; author merged directly as a minor test-only change. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests. | |
| #1187 tests: take into account the new current link. | snapcraft | merged | Merged in PR #1187 (commit 57055d1e4), updating tests to account for snapd's new ~/snap/<name>/current symlink. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. |