tests: refactor the fake snapd to not hardcode values
Metadata
Current evaluation
Merged PR refactoring fake snapd tests to remove hardcoded values. Approved by two reviewers, CI passed. Six files changed with 238 additions and 126 deletions. Requires PR #1567.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Requires #1567
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged PR refactoring fake snapd tests to remove hardcoded values. Approved by two reviewers, CI passed. Six files changed with 238 additions and 126 deletions. Requires PR #1567. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a pull request refactoring fake snapd tests to remove hardcoded values. The change depends on PR #1567 and passes all static and unit tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged pull request refactoring the fake snapd test suite to remove hardcoded values. Changes were integrated after passing static and unit tests. Requires PR #1567. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1799 tests: update the registered snap fake | snapcraft | merged | Merged following approval by one reviewer. Updated the registered snap fake in tests, changing 2 files with 4 additions and 4 deletions. | |
| #1724 tests: use the common base handler on the fake snapd server | snapcraft | merged | Merged updates to the fake snapd server test handler to prevent debug output from leaking into stdout and interfering with other tests. Approved, passed CI, and applied with a minimal three-line change. | |
| #46 tests: add fake snapd fixture | craft-parts | merged | Merged after two approvals and passing CI. Introduces a fake snapd fixture to test snap package handling in craft-parts.packages. Adds 212 lines across two files. Windows compatibility limitations were noted for separate follow-up. | |
| #5689 fix: remove unnecessary snapd_snap flag (#5316) | snapcraft | merged | PR #5316 merged, removing the unnecessary snapd_snap flag across two files and deleting 14 lines. The change received three approvals, passed all CI checks, and was successfully integrated. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. | |
| #1652 tests: fork skip into snaps_tests | snapcraft | merged | Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. | |
| #3024 tests: remove usage of FakeApt fixtures in lifecycle | snapcraft | merged | Merged changes replacing FakeApt fixtures in lifecycle tests with targeted mock.patch calls and related cleanup. Approved by one reviewer and passed CI checks. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged. | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. |