Enhanced fake store to detect that metadata can't be pushed prior to pushing the binary, and fixed the test
Metadata
Current evaluation
Merged changes enhance the fake store to enforce binary upload before metadata push. Fixed a broken integration test that incorrectly assumed metadata could be pushed first. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
This is because the real store needs for the binary of snap to be first pushed before really the metadata can be sent.
This was already understood by snapcraft (the error message when that doesn't happen express the problem correctly) but one integration test was incorrectly built (see [this failure](https://travis-ci.org/snapcore/snapcraft/jobs/308248189)).
So I fixed the fake store to make that bad test fail, and then fixed the test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes enhance the fake store to enforce binary upload before metadata push. Fixed a broken integration test that incorrectly assumed metadata could be pushed first. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enhanced the fake store to enforce binary upload before metadata push, correcting a flawed integration test that previously bypassed this requirement. Updated tests and refactored build logic to ensure proper validation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enhanced the fake store to enforce binary push before metadata push, correcting a flawed integration test. Refactored test setup for clarity and resolved unit test failures. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2086 tests: update metadata store integration test, no previous push required | snapcraft | merged | Merged test updates to accommodate new store behavior allowing metadata updates without a prior push. The change passed CI and review, aligning the test suite with a feature currently in staging and preparing for production rollout. | |
| #1634 Push metadata to the Store. | snapcraft | merged | Successfully merged changes to push snap metadata to the store. Resolved initial CI and CLA failures, updated error messages per reviewer feedback, replaced metadata terminology, and added integration tests. Approved by two reviewers. |