Enhanced fake store to detect that metadata can't be pushed prior to pushing the binary, and fixed the test
Metadata
Current evaluation
Merged #1766 in commit 558cdfbc2: the fake store now rejects metadata pushes before binaries, and the integration test was corrected to push the snap first.
Resolution: closed resolved
Reason: PR #1766 was merged as commit 558cdfbc2. It added binary-before-metadata enforcement to the fake store and fixed the integration test's upload order.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is because the real store needs for the binary of snap to be first pushed before really the metadata can be sent.
This was already understood by snapcraft (the error message when that doesn't happen express the problem correctly) but one integration test was incorrectly built (see [this failure](https://travis-ci.org/snapcore/snapcraft/jobs/308248189)).
So I fixed the fake store to make that bad test fail, and then fixed the test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1766 in commit 558cdfbc2: the fake store now rejects metadata pushes before binaries, and the integration test was corrected to push the snap first. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1766: the fake store now rejects metadata uploads before binary upload, matching the real store, and the incorrectly constructed integration test was fixed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes enhance the fake store to enforce binary upload before metadata push. Fixed a broken integration test that incorrectly assumed metadata could be pushed first. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enhanced the fake store to enforce binary upload before metadata push, correcting a flawed integration test that previously bypassed this requirement. Updated tests and refactored build logic to ensure proper validation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2086 tests: update metadata store integration test, no previous push required | snapcraft | merged | Merged PR #2086 in commit 3882853b7, updating the metadata-store integration test for approved snap names whose metadata can be changed before any revision push. | |
| #1634 Push metadata to the Store. | snapcraft | merged | Merged Store push-metadata support in canonical/snapcraft#1634 (commit 2f61ad042), with clearer failure guidance and integration coverage. |