← Back to issue list

tests: update metadata store integration test, no previous push required

View original Github issue

Metadata

Project
snapcraft
Number
#2086
Type
pull request
State
merged
Author
matiasb
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2086 in commit 3882853b7, updating the metadata-store integration test for approved snap names whose metadata can be changed before any revision push.

Resolution: closed resolved

Reason: PR #2086 was approved and merged as commit 3882853b7. The test now reflects store initialization on snap-name approval, removing the prior requirement to push a revision.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [X] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [X] Have you successfully run `./runtests.sh static`? - [X] Have you successfully run `./runtests.sh unit`? ----- We have implemented some changes in the store initializing the snap package on snap name approval, allowing to update the snap metadata (through web UI or snapcraft) without needing to push any revision.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2086 in commit 3882853b7, updating the metadata-store integration test for approved snap names whose metadata can be changed before any revision push.
stealth/space-bunny-alpha — closed resolved Merged PR #2086 (3882853b7), updating metadata-store integration tests for the new behavior allowing metadata updates after snap-name approval without a previous push.
qwen/qwen3.6-35b-a3b — — Merged test updates to accommodate new store behavior allowing metadata updates without a prior push. The change passed CI and review, aligning the test suite with a feature currently in staging and preparing for production rollout.
qwen3.6-35b-a3b-mtp-q6 — — Merged to update the metadata store integration test, aligning with a new store feature that permits metadata updates without a prior push. Changes were validated during pre-deployment testing ahead of production rollout.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1766 Enhanced fake store to detect that metadata can't be pushed prior to pushing the binary, and fixed the test snapcraft merged Merged #1766 in commit 558cdfbc2: the fake store now rejects metadata pushes before binaries, and the integration test was corrected to push the snap first.
75%
#1797 tests: update the snap name already registered for store tests snapcraft merged Updated store tests to use a currently registered, non-revoked snap after the previous test name was revoked; merged as commit 4cf4f33a.
74%
#1964 Fix Store integration tests with updated snap name registration error messages (take 2) snapcraft merged Merged in canonical/snapcraft#1964 as commit 44ecb321a, updating Store integration tests for new snap-name registration errors; it supersedes #1963.
71%
#1963 Fix Store integration tests with updated snap name registration error messages snapcraft closed PR #1963 (maxiberta) updated Store integration tests for new snap-name validation errors but was closed unmerged by the author on 2018-02-28 in favour of #1964, which merged as commit 44ecb321a.
71%
#1634 Push metadata to the Store. snapcraft merged Merged Store push-metadata support in canonical/snapcraft#1634 (commit 2f61ad042), with clearer failure guidance and integration coverage.
71%
#1984 tests: update store tests user snapcraft merged Merged PR #1984 (3c313dab1), updating the Store test account, removing two obsolete tests, and revising related test data, documentation, and warnings.
70%