← Back to issue list

catkin-tools plugin: use stage-packages

View original Github issue

Metadata

Project
snapcraft
Number
#1779
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1779 (ebc4f2ce2): catkin-tools now uses stage-packages for clean-system builds, with a snapd-suite integration test.

Resolution: closed resolved

Reason: The approved PR was merged as commit ebc4f2ce2. It changed catkin-tools from build-packages to stage-packages and added snapd-suite integration coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Currently the catkin-tools plugin uses `build-packages` for its build dependency instead of `stage-packages`, which fails on clean systems. Use `stage-packages` instead. Also, since this would have been caught by an integration test, add one of those as well (to the snapd suite, specifically).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1779 (ebc4f2ce2): catkin-tools now uses stage-packages for clean-system builds, with a snapd-suite integration test.
stealth/space-bunny-alpha — closed resolved Merged PR #1779 via commit ebc4f2ce2, switching catkin-tools to stage-packages and adding a snapd integration test.
stealth/space-bunny-alpha — closed resolved Merged #1779 (commit ebc4f2ce2), switching catkin-tools to stage-packages to fix clean-system builds and adding a snapd-suite integration test.
qwen/qwen3.6-35b-a3b — — Merged a fix switching the catkin-tools plugin from build-packages to stage-packages, resolving clean system failures. Added an integration test. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for catkin-tools plugin to use stage-packages instead of build-packages, resolving dependency failures on clean systems. Added regression integration test. Approved and merged by maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2525 catkin plugin: check stage-snaps for ROS dependencies snapcraft merged Merged #2525 as d1c5f1b00, updating the catkin plugin to honor ROS dependencies supplied by stage-snaps and avoid redundant fetches.
75%
#1743 catkin plugin: support building entire workspace snapcraft merged Merged #1743 in commit ec4cac26a, making catkin-packages optional so the Catkin plugin builds the entire workspace when omitted; this also resolves snapcraft#1713.
74%
#1658828 Catkin plugin stages compilers snapcraft (launchpad) closed Catkin no longer stages compilers: snapcore/snapcraft#1070 (ea8736af4) moved them to an alternate work area, keeping compiler bloat out of ROS snaps.
73%
#1070 catkin plugin: don't stage compilers. snapcraft merged Merged PR #1070 as commit ea8736af4, moving required Catkin compilers to an alternate work area so they are available during builds but excluded from final snaps; fixes LP #1658828.
73%
#1721168 Catkin plugin: support building the entire workspace snapcraft (launchpad) closed Implemented in snapcraft PR #1743 (commit ec4cac26a, "catkin plugin: support building entire workspace"), merged ~Nov 2017. catkin-packages became optional: omitting it builds the whole workspace, while an empty list still means no packages.
73%
#175 Catkin plugin: Refactor build. snapcraft merged Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests.
72%
#2545 catkin plugin: use build-packages for compilers snapcraft merged Merged PR #2545 in commit ddb2d2627, replacing Catkin's side-loaded compiler workaround with required build-packages and fixing LP: #1827148 rebuild failures.
71%
#1713 catkin plugin: support for building all packages in a given workspace snapcraft closed Implemented workspace-wide Catkin builds: omitting catkin-packages now builds every package. Merged in canonical/snapcraft#1743 via commit ec4cac26a.
71%
#840 Catkin plugin: build with in-snap python. snapcraft merged Merged #840 as 7f9fa3ac1, fixing LP #1628990 by using in-snap Python during Catkin builds and adding gcc, libc-dev, and make as build packages.
70%
#1663385 Catkin plugin: Staging area not suitable for building other parts snapcraft (launchpad) closed Catkin staging output was made reusable by later parts: merged snapcraft#1130 rewrote ROS-specific paths after building, fixing LP #1663385.
70%