← Back to issue list

Catkin plugin: build with in-snap python.

View original Github issue

Metadata

Project
snapcraft
Number
#840
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #840 as 7f9fa3ac1, fixing LP #1628990 by using in-snap Python during Catkin builds and adding gcc, libc-dev, and make as build packages.

Resolution: closed resolved

Reason: PR #840 was approved and merged as commit 7f9fa3ac1. The change fixes LP #1628990 by ensuring Catkin builds use the snap's Python and include the required compiler and build tools.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Our test cases all had python installed on the system, so the fact that the plugin used it went unnoticed. This PR fixes LP: [#1628990](https://bugs.launchpad.net/snapcraft/+bug/1628990) by using the in-snap python for build-time as well as run-time. It also pulls in gcc, libc-dev, and make as build packages.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #840 as 7f9fa3ac1, fixing LP #1628990 by using in-snap Python during Catkin builds and adding gcc, libc-dev, and make as build packages.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#840 (7f9fa3ac1), fixing LP #1628990 by using in-snap Python during Catkin builds and adding gcc, libc-dev, and make.
qwen/qwen3.6-35b-a3b — — Merged after approval. Resolves LP #1628990 by configuring the catkin plugin to use in-snap Python for both build and run times. Adds gcc, libc-dev, and make as build dependencies.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the Catkin plugin to use in-snap Python during build time instead of relying on system Python, resolving Launchpad bug #1628990. The change also adds gcc, libc-dev, and make as build dependencies.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft (launchpad)#1628990 (confidence 100%)

    Launchpad bug 1628990 reported that the Catkin example failed on a vanilla installation; PR #840 directly fixed and closed it.

Related issues

Issue Project State Summary Similarity
#1628990 Catkin plugin: example doesn't build on vanilla install snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#840 (commit 7f9fa3ac1): Catkin builds now use in-snap Python and add gcc, libc-dev and make as build-packages, so the example builds on a vanilla system. Closed by maintainer ~kyrofa.
82%
#175 Catkin plugin: Refactor build. snapcraft merged Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests.
78%
#232 Catkin plugin: Use in-snap python instead of OS-provided. snapcraft merged Merged PR #232 (fe9ca74c9), fixing Catkin on Xenial by using /usr/bin/env Python shebangs and PATH-resolved Python in 10.ros.sh.
76%
#881 Catkin plugin: Python nodes require gcc/g++ too. snapcraft merged Merged as commit 2f0c8ba04: catkin plugin now stages gcc/g++ unconditionally at the start of the build (instead of only when roscpp is a dependency), fixing LP bug #1638317.
74%
#1658828 Catkin plugin stages compilers snapcraft (launchpad) closed Catkin no longer stages compilers: snapcore/snapcraft#1070 (ea8736af4) moved them to an alternate work area, keeping compiler bloat out of ROS snaps.
74%
#1638317 Catkin plugin doesn't build pure python workspaces snapcraft (launchpad) closed Catkin plugin only staged g++ when roscpp was a dependency, breaking pure-Python ROS workspaces. Fixed by snapcore/snapcraft PR #881 (merged as 2f0c8ba04), staging gcc/g++ unconditionally; issue closed by maintainer ~kyrofa.
74%
#1721168 Catkin plugin: support building the entire workspace snapcraft (launchpad) closed Implemented in snapcraft PR #1743 (commit ec4cac26a, "catkin plugin: support building entire workspace"), merged ~Nov 2017. catkin-packages became optional: omitting it builds the whole workspace, while an empty list still means no packages.
73%
#1743 catkin plugin: support building entire workspace snapcraft merged Merged #1743 in commit ec4cac26a, making catkin-packages optional so the Catkin plugin builds the entire workspace when omitted; this also resolves snapcraft#1713.
71%
#1664776 Catkin plugin: support building with an underlay snapcraft (launchpad) closed Catkin underlay support landed in snapcore/snapcraft#1140 (cab0b3806); follow-up #1186 added a ROS content-sharing demo.
71%
#1693380 Transition catkin plugin to use catkin build snapcraft (launchpad) closed Superseded by merged PR canonical/snapcraft#1593 (7e31fa0dd), which added a separate beta catkin-tools plugin using catkin build while preserving catkin_make behavior.
71%