← Back to issue list

Catkin plugin: build with in-snap python.

View original Github issue

Metadata

Project
snapcraft
Number
#840
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. Resolves LP #1628990 by configuring the catkin plugin to use in-snap Python for both build and run times. Adds gcc, libc-dev, and make as build dependencies.

Suggested action:

No scores available.

Issue body

Our test cases all had python installed on the system, so the fact that the plugin used it went unnoticed. This PR fixes LP: [#1628990](https://bugs.launchpad.net/snapcraft/+bug/1628990) by using the in-snap python for build-time as well as run-time. It also pulls in gcc, libc-dev, and make as build packages.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Resolves LP #1628990 by configuring the catkin plugin to use in-snap Python for both build and run times. Adds gcc, libc-dev, and make as build dependencies.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the Catkin plugin to use in-snap Python during build time instead of relying on system Python, resolving Launchpad bug #1628990. The change also adds gcc, libc-dev, and make as build dependencies.
qwen3.6-35b-a3b-mtp-q6 Merged. The Catkin plugin now uses in-snap Python for build and runtime, eliminating system Python dependency. Added gcc, libc-dev, and make as build packages to resolve Launchpad bug #1628990.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#232 Catkin plugin: Use in-snap python instead of OS-provided. snapcraft merged Merged a fix for the Catkin plugin failing on Ubuntu Xenial due to removed OS Python 2. Shebangs now use /usr/bin/env python and 10.ros.sh uses path-based Python, resolving review-flagged file conflicts and missing attributes.
75%
#881 Catkin plugin: Python nodes require gcc/g++ too. snapcraft merged Merged a fix for Launchpad bug #1638317 updating the Catkin plugin to unconditionally stage gcc and g++ at the beginning. This ensures Python nodes compile correctly regardless of roscpp dependencies. The change modifies two files.
72%
#175 Catkin plugin: Refactor build. snapcraft merged Merged after addressing reviewer feedback on error handling and testing strategy. The update refactored the Catkin plugin build process, simplified build logic, extracted dependency resolution, added a source-space keyword, and achieved 100% unit test coverage.
71%
#1070 catkin plugin: don't stage compilers. snapcraft merged Merged to master. The catkin plugin now routes compilers to an alternate working area instead of staging them, resolving LP #1658828 and preventing their inclusion in the final snap. Approved, passed CI, and merged.
70%