← Back to issue list

tests: python plugin integration tests moved to a separate suite

View original Github issue

Metadata

Project
snapcraft
Number
#1791
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1791 (commit 91b6639f2) by come-maiz: Python plugin integration tests were moved out of the oversized plugins suite into their own suite, following the same split already done for catkin in #1760.

Resolution: closed resolved

Reason: The pull request was approved and merged into master as commit 91b6639f2, splitting the Python plugin integration tests into a separate suite to stop the plugins suite timing out.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The plugins suite is again causing time outs because it's too big. We discussed about an ugly hack to split the suite, and we already applied it to the catkin plugin. Here we are doing the same for python, and we might have to do it again for ruby or catkin. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1791 (commit 91b6639f2) by come-maiz: Python plugin integration tests were moved out of the oversized plugins suite into their own suite, following the same split already done for catkin in #1760.
stealth/space-bunny-alpha — closed resolved Merged PR #1791 as 91b6639f2, splitting Python plugin integration tests into a separate suite to prevent timeouts in the oversized plugins suite.
qwen/qwen3.6-35b-a3b — — Merged. Python plugin integration tests were split into a separate suite to prevent timeout failures in the main plugins test suite. Approved by reviewer, passed CI, and modified seven files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Python plugin integration tests were split into a separate suite to resolve timeouts in the oversized plugins test suite, mirroring a prior split applied to the catkin plugin.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1760 (confidence 88%)

    Precedent PR c97c45131 'tests: move the catkin integration tests to a separate suite' applied the same split that #1791 extends to python.

Related issues

Issue Project State Summary Similarity
#1944 tests: split the plugins tests in the same directory snapcraft merged Merged PR #1944 in commit 2dd0377e9, consolidating split plugin test suites in one package so Python 3.6 unittest discovery no longer failed on directories missing __init__.py.
74%
#947 tests: deduplicate tests for python-based plugins craft-parts merged Merged PR #947 as commit 1a2631e1, consolidating duplicated Python plugin tests into BasePythonPlugin coverage and closing #935.
72%
#1014 tests: reorganize plugin tests into subdirectory. snapcraft merged Merged #1014 as d97c00e8f, moving plugin unit tests into a dedicated subdirectory to make the suite manageable and resolve LP #1651903.
71%
#1760 tests: move the catkin integration tests to a separate suite snapcraft merged Merged in snapcraft#1760 as commit c97c45131, moving Catkin integration tests to a separate suite to reduce timeouts in the main plugins suite.
70%