← Back to issue list

tests: do not hit the network in python unit tests

View original Github issue

Metadata

Project
snapcraft
Number
#1792
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged to prevent Python unit tests from hitting the network, resolving daily PPA build failures. Approved by one reviewer, passed CI, and modified one file.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This is causing our daily PPA to fail to build.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to prevent Python unit tests from hitting the network, resolving daily PPA build failures. Approved by one reviewer, passed CI, and modified one file.
qwen3.6-35b-a3b-mtp-q6 Merged to prevent Python unit tests from making network calls, resolving daily PPA build failures. The change was integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Merged changes to prevent Python unit tests from making network calls, resolving daily PPA build failures. The update isolates tests from external dependencies, ensuring reliable automated builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1619 tests: don't hit internet in ros2 units snapcraft merged Merged to prevent ROS2 unit tests from accessing the internet, resolving PPA test failures. Approved by two reviewers with passing CI checks. Changed 1 file (+5/-1).
80%
#3206 tests: add missing asserts to python unit tests snapcraft merged Merged update adding missing asserts to Python unit tests. Fixed broken tests after removing virtual environment activate usage. Approved by one reviewer, passed CI, and modified one file with 22 additions and 16 deletions.
70%