tests: add missing asserts to python unit tests
Metadata
Current evaluation
Merged update adding missing asserts to Python unit tests. Fixed broken tests after removing virtual environment activate usage. Approved by one reviewer, passed CI, and modified one file with 22 additions and 16 deletions.
Suggested action: —
No scores available.
Issue body
Fix broken tests that fell out of date after the removal
of virtual environment `activate` usage.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged update adding missing asserts to Python unit tests. Fixed broken tests after removing virtual environment activate usage. Approved by one reviewer, passed CI, and modified one file with 22 additions and 16 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates adding missing asserts to Python unit tests. The changes fix broken tests that became outdated after removing virtual environment activate usage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates adding missing asserts to Python unit tests. The changes fix broken tests that became outdated after removing virtual environment activate usage. All validation checks passed and the code was successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5375 test: fix command tests | snapcraft | merged | Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions. | |
| #617 test: make tests work in python 3.12+ | craft-parts | merged | Merged to update the test suite for Python 3.12+ compatibility. Approved by two reviewers, the change modifies five files (+36/-26 lines) to resolve version-specific test failures. | |
| #1792 tests: do not hit the network in python unit tests | snapcraft | merged | Merged to prevent Python unit tests from hitting the network, resolving daily PPA build failures. Approved by one reviewer, passed CI, and modified one file. | |
| #1398 tests: fix issues with python 3.6 | snapcraft | merged | Merged fix for Python 3.6 test compatibility. Approved by one reviewer, modified three files (+34/-7). Resolves Launchpad bug #1699009. | |
| #595 fix(tests): fix a test broken in Python 3.12.8 | craft-application | merged | Merged a fix for a test failing after Python 3.12.8 updated argparse choices quoting. Approved by two reviewers, passed CI, and adjusted one file to match the new standard library behavior. |