← Back to issue list

tests: add more unit tests for formatting_utils

View original Github issue

Metadata

Project
snapcraft
Number
#1813
Type
pull request
State
merged
Author
konrad11901
Labels
Created
Updated
Closed

Current evaluation

Merged after adding unit tests for the format_path_variable function in formatting_utils. Review was approved, CI passed, and the author adjusted a separator to a colon prior to merge.

Suggested action:

No scores available.

Issue body

Add unit tests for the "format_path_variable" function in "formatting_utils" module. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Add unit tests which cover format_path_variable function (in formatting_utils module).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after adding unit tests for the format_path_variable function in formatting_utils. Review was approved, CI passed, and the author adjusted a separator to a colon prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged unit tests for the format_path_variable function in the formatting_utils module. The contributor adjusted a path separator to a colon prior to merge. All static and unit tests passed.
qwen3.6-35b-a3b-mtp-q6 Merged. Added unit tests for the format_path_variable function in formatting_utils. Contributor adjusted a separator to a colon per feedback, and all tests passed.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
72%
#3235 tests: fix assert ordering for error format tests snapcraft merged Merged after approval and passing CI. The changes fix assert ordering in error format tests, updating three files with 15 additions and 15 deletions.
71%