← Back to issue list

test: fix command tests

View original Github issue

Metadata

Project
snapcraft
Number
#5375
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Test-only PR by maintainer mr-cal merged as commit 28cb1b828 ("test: fix command tests (#5375)"), updating fixtures for failing command unit tests (CRAFT-4414); +17/-9 across 2 files, approved by 2 reviewers.

Resolution: closed resolved

Reason: The pull request itself was merged into the main branch as commit 28cb1b828, with no unresolved review comments, refreshing the command test fixtures that were failing under CRAFT-4414.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- Fixture updates for failing command unit tests. (CRAFT-4414)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Test-only PR by maintainer mr-cal merged as commit 28cb1b828 ("test: fix command tests (#5375)"), updating fixtures for failing command unit tests (CRAFT-4414); +17/-9 across 2 files, approved by 2 reviewers.
stealth/space-bunny-alpha — closed resolved Merged in #5375 (28cb1b828), updating fixtures for failing command unit tests.
qwen/qwen3.6-35b-a3b — — Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Updated test fixtures to resolve failing command unit tests. Merged after passing lint and test suites, addressing CRAFT-4414.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1591 tests: remove regression test for command help charmcraft merged Merged PR #1591 as commit 4501ea01, dropping the 93-line command-help regression test since the craft-application base is now stable.
73%
#4643 fix(tests): create a suitable build plan snapcraft closed PR #4643 (test fix creating a suitable build plan) was closed unmerged: maintainer mr-cal noted its commits landed via PR #4659 ("fix: update to craft-application latest"), squashed as commit aab0797cf.
73%
#3910 unit tests: minor improvement to fixture usage snapcraft merged Merged test-only PR #3910 (commit 07d949a71): small refactor of unit-test fixture usage, 8 lines changed across 2 files, no coverage change.
72%
#461 test: improve test coverage fetch-service merged Merged PR #461 via commit 76d6134, adding 270 lines of tests across three files; all CI checks passed and two reviewers approved.
70%
#1027 tests: fix broken unit test in master snapcraft merged Merged PR #1027 fixed a broken master unit test with a one-line test-only change in commit f53b45563.
70%
#1015 tests: reorganize command tests into subdirectory. snapcraft merged Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908.
70%
#3710 tests: use craft-cli lib fixtures snapcraft merged Merged PR #3710 under CRAFT-997, replacing local fixtures with craft-cli library fixtures across 11 files; merge commit 1f5901d8e.
70%