← Back to issue list

test: fix command tests

View original Github issue

Metadata

Project
snapcraft
Number
#5375
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- Fixture updates for failing command unit tests. (CRAFT-4414)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
qwen3.6-35b-a3b-mtp-q6 Updated test fixtures to resolve failing command unit tests. Merged after passing lint and test suites, addressing CRAFT-4414.
qwen3.6-35b-a3b-mtp-q6 Updated test fixtures to resolve failing command unit tests. The changes passed linting and testing, and were successfully merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1146 test: fix doc version tests craft-application merged Merged a fix for documentation version test failures accidentally introduced by PR #1140. Approved by two reviewers, passed all CI checks, and merged with a +6/-5 change across three files.
79%
#461 test: improve test coverage fetch-service merged Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing.
77%
#117 a couple of fixes for tests charmcraft merged Merged to resolve issue #105. Approved by two reviewers, the pull request implements minor test corrections across two files with a +10/-1 line change.
77%
#1787 tests: move refresh to unit folder snapcraft merged Merged a fix moving a misplaced refresh test into the unit folder. The test was previously excluded from regular runs due to the new directory structure, causing false passes. Approved by one reviewer, passed CI, and merged.
77%
#18 ci: ensure tests succeed in CI craft-application merged Merged updates to CI configuration ensuring tests pass successfully. Approved by one reviewer, modifying five files with 23 additions and 13 deletions.
76%
#3305 unit tests: fix runtests.sh not filtering tests when passed a subdirectory snapcraft merged Merged a one-line fix correcting runtests.sh to properly filter tests when a subdirectory is passed. Previously, the script ran the entire suite. Approved by two reviewers, passed CI, and merged.
76%
#1928 tests: remove duplicate tests snapcraft merged Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
76%
#278 tests: additional tests to improve coverage fetch-service merged Merged after two reviews and passing CI checks. Adds additional tests across ten files to improve code coverage, changing +386/-60 lines.
76%
#274 fix: remove dash in tests starbase merged Merged a hotfix removing a rogue dash from test files to prevent CI workflow failures. Approved by two reviewers, passed all checks, and modified one file.
76%
#458 test: improve test coverage fetch-service merged Merged after approval from two reviewers and passing CI checks. Added 370 lines of test code across five files to improve overall test coverage.
76%