← Back to issue list

tests: use a simpler test for bzr and python

View original Github issue

Metadata

Project
snapcraft
Number
#1821
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1821 as commit 6454b22f4: python plugin bzr test switched from lp:curtin to a simpler ~snappy-dev-controlled bzr repo, fixing broken tests after curtin moved off bzr.

Resolution: closed resolved

Reason: PR #1821 was merged into master as commit 6454b22f4 (2017-12-20), changing the python plugin test source from lp:curtin to a lightweight bzr repo; the author noted tests were broken before landing it. The original bzr support feature traces back to snapcraft#858.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The python plugin test used lp:curtin which recently moved to bzr. This moves the test to use a bzr repo the ~snappy-dev team controls which is also much simpler and lightweight. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1821 as commit 6454b22f4: python plugin bzr test switched from lp:curtin to a simpler ~snappy-dev-controlled bzr repo, fixing broken tests after curtin moved off bzr.
stealth/space-bunny-alpha — closed resolved Merged #1821 (commit 6454b22f4), replacing the bzr/Python test’s lp:curtin dependency with a simpler, lightweight bzr repository.
qwen/qwen3.6-35b-a3b — — Merged by the author to replace a broken python plugin test with a simpler bzr repository controlled by the ~snappy-dev team. Landed directly due to widespread test failures, updating two files with minimal changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated the Python plugin test to use a simpler bzr repository managed by the ~snappy-dev team. Fixes test failures from lp:curtin switching to bzr. Maintainer merged the change to restore CI.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#858 (confidence 55%)

    Commit a2054b8a7 'python plugin: allow usage of bzr (#858)' introduced the bzr/python test that this PR reworks.

Related issues

Issue Project State Summary Similarity
#2713 tests: completely mock bzr tests snapcraft merged PR #2713 by sergiusens was merged (commit d36264104, 'tests: completely mock bzr tests'), replacing real bzr invocations in the bzr source-plugin unit tests with mocks for speed, leaving coverage to integration tests.
70%
#5533 test: drop bzr spread tests snapcraft merged PR #5533 was merged, removing bzr spread tests after Launchpad’s Bazaar phase-out made its remotes unreachable; bzr support remains best-effort without remote coverage.
70%