tests: completely mock bzr tests
Metadata
Current evaluation
PR #2713 by sergiusens was merged (commit d36264104, 'tests: completely mock bzr tests'), replacing real bzr invocations in the bzr source-plugin unit tests with mocks for speed, leaving coverage to integration tests.
Resolution: closed resolved
Reason: The pull request was approved and merged into snapcraft as commit d36264104, changing tests/unit/plugins/test_bzr.py (+68/-20) to fully mock bzr commands. The work was later obsoleted when bzr support and its tests were dropped in #5533, but the PR itself landed as intended.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This should speed them up, there are integration tests for ensuring
the rest.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2713 by sergiusens was merged (commit d36264104, 'tests: completely mock bzr tests'), replacing real bzr invocations in the bzr source-plugin unit tests with mocks for speed, leaving coverage to integration tests. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2713 was merged, completely mocking bzr tests to speed them up while retaining integration coverage for real behavior. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes completely mocking bzr tests to improve execution speed. Approved by a reviewer, passed CI checks, and modified two files (+68/-20). Integration tests remain for validation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Completely mocked bzr tests to improve execution speed, deferring validation to integration tests. Maintainer sergiusens approved and merged the changes despite a Codecov base commit coverage warning. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#5533
(confidence 80%)
Later commit 'test: drop bzr spread tests' (#5533) removed bzr-related tests entirely after bzr support was decommissioned, superseding the tests touched here.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2716 tests: completely mock subversion tests | snapcraft | merged | Merged PR #2716 (commit 518083bb2) fully mocked the Subversion plugin unit tests in snapcraft, cutting their runtime while keeping integration tests for real behaviour. | |
| #2714 tests: completely mock mercurial tests | snapcraft | merged | Merged PR #2714 completely mocked Mercurial unit tests to speed them up while retaining integration coverage; implemented in commit f22b5b07b. | |
| #1821 tests: use a simpler test for bzr and python | snapcraft | merged | Merged #1821 as commit 6454b22f4: python plugin bzr test switched from lp:curtin to a simpler ~snappy-dev-controlled bzr repo, fixing broken tests after curtin moved off bzr. |