← Back to issue list

tests: completely mock bzr tests

View original Github issue

Metadata

Project
snapcraft
Number
#2713
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes completely mocking bzr tests to improve execution speed. Approved by a reviewer, passed CI checks, and modified two files (+68/-20). Integration tests remain for validation.

Suggested action:

No scores available.

Issue body

This should speed them up, there are integration tests for ensuring the rest. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes completely mocking bzr tests to improve execution speed. Approved by a reviewer, passed CI checks, and modified two files (+68/-20). Integration tests remain for validation.
qwen3.6-35b-a3b-mtp-q6 Merged. Completely mocked bzr tests to improve execution speed, deferring validation to integration tests. Maintainer sergiusens approved and merged the changes despite a Codecov base commit coverage warning.
qwen3.6-35b-a3b-mtp-q6 Merged into main branch. Completely mocks bzr tests to improve execution speed, deferring full validation to existing integration tests. Changes were accepted and integrated by maintainer sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2714 tests: completely mock mercurial tests snapcraft merged Merged changes that completely mock Mercurial tests to improve execution speed, relying on integration tests for validation. Approved by reviewer, passed CI, and modified two files.
81%
#1128 tests: support bzr branches for external tests snapcraft merged Merged update adding bzr branch support to external tests. Approved by two reviewers, it modifies one file (+21/-2 lines) to resolve Launchpad bug #1663294.
76%
#2716 tests: completely mock subversion tests snapcraft merged Merged into master to accelerate test execution by fully mocking subversion tests. Approved by reviewers, passed CI, and caused a negligible 0.02% decrease in overall test coverage.
75%
#1821 tests: use a simpler test for bzr and python snapcraft merged Merged by the author to replace a broken python plugin test with a simpler bzr repository controlled by the ~snappy-dev team. Landed directly due to widespread test failures, updating two files with minimal changes.
74%
#82 test: improve integration testing craft-store merged Merged improvements to integration testing across eight files. The update works around external fork credential limitations by running full tests only after merging to main. Approved by one reviewer and passed CI.
74%
#1357 tests: do not break a systems `bzr whoami` snapcraft merged Merged a fix preventing tests from modifying the system's bzr whoami configuration. Changes span 2 files with 14 additions and 23 deletions. Approved by one reviewer and resolved LP #1693839.
73%
#278 tests: additional tests to improve coverage fetch-service merged Merged after two reviews and passing CI checks. Adds additional tests across ten files to improve code coverage, changing +386/-60 lines.
72%
#461 test: improve test coverage fetch-service merged Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing.
71%
#1928 tests: remove duplicate tests snapcraft merged Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
70%