← Back to issue list

tests: call file directly for the HasArchitecture checker

View original Github issue

Metadata

Project
snapcraft
Number
#1868
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged test updates to call the file directly for the HasArchitecture checker, resolving LP: #1742504. The change modified one file (+18/-9 lines), passed CI checks, and was approved by a maintainer.

Suggested action:

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged test updates to call the file directly for the HasArchitecture checker, resolving LP: #1742504. The change modified one file (+18/-9 lines), passed CI checks, and was approved by a maintainer.
qwen3.6-35b-a3b-mtp-q6 Merged test modification to invoke the file command directly for the HasArchitecture checker, addressing Launchpad bug 1742504.
qwen3.6-35b-a3b-mtp-q6 Merged test updates to invoke the file command directly for the HasArchitecture checker. Resolves Launchpad bug 1742504 and passes static and unit tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1895 tests: check that architecture "all" works charmcraft merged Merged following two approvals. Introduces tests for architecture all, resolving issue 1698. Depends on PR 1894. Updated 5 files (+70/-38).
75%
#1292 tests: fix the recording tests to work in multiple architectures snapcraft merged Merged a four-line change that corrected recording tests for cross-architecture compatibility. Approved by one reviewer, the update caused zero coverage impact and was successfully integrated into the master branch.
70%