← Back to issue list

tests: check that architecture "all" works

View original Github issue

Metadata

Project
charmcraft
Number
#1895
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged following two approvals. Introduces tests for architecture all, resolving issue 1698. Depends on PR 1894. Updated 5 files (+70/-38).

Suggested action:

No scores available.

Issue body

Fixes #1698, requires https://github.com/canonical/charmcraft/pull/1894

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following two approvals. Introduces tests for architecture all, resolving issue 1698. Depends on PR 1894. Updated 5 files (+70/-38).
qwen3.6-35b-a3b-mtp-q6 Merged to resolve issue #1698 by adding tests that verify architecture all functionality. Integration depended on prerequisite PR #1894.
qwen3.6-35b-a3b-mtp-q6 Merged to add tests verifying the "all" architecture functionality. Resolves issue #1698 and depends on PR #1894. Changes were integrated into the main branch, confirming the architecture handling works as expected.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1868 tests: call file directly for the HasArchitecture checker snapcraft merged Merged test updates to call the file directly for the HasArchitecture checker, resolving LP: #1742504. The change modified one file (+18/-9 lines), passed CI checks, and was approved by a maintainer.
75%
#1292 tests: fix the recording tests to work in multiple architectures snapcraft merged Merged a four-line change that corrected recording tests for cross-architecture compatibility. Approved by one reviewer, the update caused zero coverage impact and was successfully integrated into the master branch.
74%
#4160 tests: remove arch_triplet from unit test snapcraft merged Merged a unit test fix removing remaining arch_triplet references. The change resolves file overlap from two prior PRs. Approved by one reviewer, passed CI, and deleted two lines from a single test file.
72%
#2014 integration tests: snap tests shouldn't be arch-specific snapcraft merged Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.
71%
#1245 tests: add parallel build test charmcraft merged Merged after three approvals. Added a parallel build test to resolve issue #1138, modifying three files with 44 additions and 2 deletions. All checks passed and the change was integrated.
71%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
70%
#4172 tests: remove arch_triplet from unit test (#4160) snapcraft merged Merged changes removing arch_triplet from unit tests. The update deleted two lines in one file, passed CI checks, and received reviewer approval before integration.
70%