← Back to issue list

extractors: replace desktop file ids with paths

View original Github issue

Metadata

Project
snapcraft
Number
#1879
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged after review and conflict resolution. Replaces desktop file IDs with paths in extractors, shifting translation logic to the appstream extractor. Approved by reviewer and passed CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- @kyrofa and I discussed about moving the task of translating from desktop file id to desktop file path to the appstream extractor. This opens the door to save in the metadata the contents of the file, instead of the path. But we haven't yet decided if that next step would be good.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after review and conflict resolution. Replaces desktop file IDs with paths in extractors, shifting translation logic to the appstream extractor. Approved by reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Successfully merged. Replaced desktop file IDs with paths in extractors, moving translation logic to the appstream extractor to enable future metadata storage. Conflicts were resolved during review.
qwen3.6-35b-a3b-mtp-q6 Merged changes replacing desktop file IDs with paths in extractors. Translation logic moved to the appstream extractor to enable future metadata storage of file contents. Merge conflicts were resolved prior to integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1853 extractors: support appstream icon and desktop snapcraft merged Merged PR adding AppStream icon and desktop file support to extractors. Approved by two reviewers and passed CI after fixing test failures caused by string casting side effects. Closes issue #1828.
78%