← Back to issue list

extractors: support appstream icon and desktop

View original Github issue

Metadata

Project
snapcraft
Number
#1853
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit ce3209468: AppStream extractors now adopt icon and desktop metadata (icon paths, desktop file IDs) from .metainfo.xml. Closes issue #1828.

Resolution: closed resolved

Reason: PR #1853 was approved by 2 reviewers and merged into the mainline as commit ce3209468 ("extractors: support appstream icon and desktop (#1853)"). It explicitly declares "Closes #1828", implementing the requested desktop and icon support; the code survives today in snapcraft/meta/appstream.py (_get_desktop_file_ids_from_nodes, _extract_icon).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Closes #1828.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit ce3209468: AppStream extractors now adopt icon and desktop metadata (icon paths, desktop file IDs) from .metainfo.xml. Closes issue #1828.
stealth/space-bunny-alpha — closed resolved AppStream extractors gained icon and desktop support, closing #1828; merged as snapcore/snapcraft#1853 in commit ce3209468.
qwen/qwen3.6-35b-a3b — — Merged PR adding AppStream icon and desktop file support to extractors. Approved by two reviewers and passed CI after fixing test failures caused by string casting side effects. Closes issue #1828.
qwen3.6-35b-a3b-mtp-q6 — — Added appstream icon and desktop support to extractors. Resolved initial test failures caused by string casting side effects by adding conditional checks. Merged and closed issue #1828.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: snapcore/snapcraft#1828 (confidence 95%)

    The feature request this PR implements and closes; now delivered by commit ce3209468.

  • Related To: snapcore/snapcraft#1826 (confidence 85%)

    Merged prerequisite (commit 9cb05f4c5) that introduced the AppStream metadata extractor for parts; #1853 extends it with icon/desktop fields.

  • Related To: snapcore/snapcraft#1861 (confidence 80%)

    Merged follow-up (commit d49c2c202) extending the same extractor to appdata.xml files.

Related issues

Issue Project State Summary Similarity
#1861 extractors: also support appdata.xml appstream files. snapcraft merged Merged PR #1861, adding extractor support for AppStream appdata.xml files, in commit d49c2c202.
75%
#1828 Support desktop and icon in appstream handler snapcraft closed AppStream metadata gained icon and desktop support in merged PR canonical/snapcraft#1853 (commit ce3209468), closing the feature request.
74%
#1879 extractors: replace desktop file ids with paths snapcraft merged Merged PR #1879 as 75a919b2c, replacing desktop file IDs with paths and moving ID translation into the AppStream extractor.
73%
#2630 appstream extractor: skip non icon file paths snapcraft merged Merged PR #2630 as commit f03d13aa0, updating the AppStream extractor to skip non-icon file paths during icon resolution.
72%
#1826 extractors: support appstream metadata in parts snapcraft merged Merged PR #1826 (commit 9cb05f4c5) added an AppStream metadata extractor for parts, initially extracting summary and description. Credits @elopio; closes feature request #1694. Follow-ups: #1853, #1861, #2430.
71%