extractors: support appstream icon and desktop
Metadata
Current evaluation
Merged PR adding AppStream icon and desktop file support to extractors. Approved by two reviewers and passed CI after fixing test failures caused by string casting side effects. Closes issue #1828.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Closes #1828.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged PR adding AppStream icon and desktop file support to extractors. Approved by two reviewers and passed CI after fixing test failures caused by string casting side effects. Closes issue #1828. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Added appstream icon and desktop support to extractors. Resolved initial test failures caused by string casting side effects by adding conditional checks. Merged and closed issue #1828. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after resolving initial test failures by adding conditional checks for string casting side effects. Adds appstream icon and desktop support to extractors. Closes #1828. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2543 extractors: fix typo in appstream icon unit test | snapcraft | merged | Merged a fix for a typo in the appstream icon unit test that duplicated the missing icon scenario. The change ensures the existing icon case is properly validated. Approved by one reviewer, passed CI, and merged into master. | |
| #1879 extractors: replace desktop file ids with paths | snapcraft | merged | Merged after review and conflict resolution. Replaces desktop file IDs with paths in extractors, shifting translation logic to the appstream extractor. Approved by reviewer and passed CI checks. | |
| #1861 extractors: also support appdata.xml appstream files. | snapcraft | merged | Merged into the main branch after passing CI checks and receiving approval. Adds support for appdata.xml appstream files to the extractors module with minor code changes across two files. | |
| #2435 Appstream desktop | snapcraft | merged | Merged pull request adding Appstream desktop support. Approved by one reviewer with no unresolved comments. CI passed, modifying 10 files with 95.91% diff coverage. | |
| #2512 many: better handling of appstream icons | snapcraft | merged | Merged changes improve AppStream icon handling by resolving stock icons at packaging time and falling back to desktop file definitions. Reviewers noted spec compliance concerns with theme parsing, but the PR was approved and merged. |