elf: readelf dependency
Metadata
Current evaluation
Merged. The change ensures the readelf dependency is properly added and utilized based on the execution environment. Approved by one reviewer with passing checks.
Suggested action: —
No scores available.
Issue body
Make sure the dependency is added and that it is used properly depending on where it is running.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. The change ensures the readelf dependency is properly added and utilized based on the execution environment. Approved by one reviewer with passing checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The pull request addressed adding and properly utilizing the readelf dependency for ELF processing but was not integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed after passing static and unit tests, resolving the readelf dependency requirement for proper ELF handling across environments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1870 elf: remove dependency on magic | snapcraft | merged | Merged. Replaced python-magic dependency with readelf for ELF parsing, including general code cleanup. Validated across i386, armhf, and arm64 architectures. Approved by reviewer and passed CI checks. | |
| #1903 elf: use surrogate escape when decoding readelf output | snapcraft | merged | Merged a one-line change to use surrogate escape when decoding readelf output, resolving Launchpad bug 1746639. The fix handles non-UTF-8 characters in ELF parsing and was approved without formal review. | |
| #2746 elf: handle missing dependencies not found on system | snapcraft | merged | Merged updates to handle missing ELF dependencies when ldd fails to resolve them. The change prevents filtering unresolved libraries, refactors ldd parsing for reliability, and adds unit tests. Approved by one reviewer and passed CI checks. |