← Back to issue list

elf: readelf dependency

View original Github issue

Metadata

Project
snapcraft
Number
#1899
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; its environment-specific readelf dependency work was replaced by merged PR #1902 (d338ef5c7), which used bundled tools when running as a snap.

Resolution: closed superseded

Reason: PR #1899 was closed without merging. Merged PR #1902, commit d338ef5c7, implemented the intended bundled readelf behavior; PR #1913 later replaced readelf parsing with pyelftools.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Make sure the dependency is added and that it is used properly depending on where it is running. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; its environment-specific readelf dependency work was replaced by merged PR #1902 (d338ef5c7), which used bundled tools when running as a snap.
stealth/space-bunny-alpha — closed superseded Closed unmerged; #1902 (d338ef5c7) added in-snap readelf handling, later superseded by #1913 (9e4e88629), which replaced readelf with pyelftools.
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by #1902 (d338ef5c7), which used bundled readelf; #1913 (9e4e88629) later replaced readelf with pyelftools.
stealth/space-bunny-alpha — closed superseded Closed unmerged; #1902 (d338ef5c7) addressed the environment-dependent readelf dependency. Later, #1913 (9e4e88629) replaced readelf with pyelftools.
qwen/qwen3.6-35b-a3b — — Merged. The change ensures the readelf dependency is properly added and utilized based on the execution environment. Approved by one reviewer with passing checks.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The pull request addressed adding and properly utilizing the readelf dependency for ELF processing but was not integrated.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#1902 (confidence 99%)

    Merged commit d338ef5c7 used the in-snap readelf when Snapcraft runs as a snap.

  • Related To: snapcraft#1913 (confidence 96%)

    Merged commit 9e4e88629 replaced readelf-based ELF parsing with pyelftools.

Related issues

Issue Project State Summary Similarity
#1870 elf: remove dependency on magic snapcraft merged Merged PR #1870 in commit d20b9678d, replacing python-magic with readelf for ELF parsing and cleaning up the implementation.
71%