← Back to issue list

tests: setup the correct environment for adt

View original Github issue

Metadata

Project
snapcraft
Number
#1907
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1907 (commit 570eaf8c9) fixing the ADT/autopkgtest environment for snapcraft's test suite — a one-line change to the ADT test configuration, approved by one reviewer and merged into master in Feb 2018.

Resolution: closed resolved

Reason: The pull request was approved (1 reviewer, 0 unresolved comments) and merged as commit 570eaf8c9, which corrects the environment setup used when running the test suite under adt. Its follow-up, PR #1908 (commit a5c7d9e55), continued the ADT test fixes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1907 (commit 570eaf8c9) fixing the ADT/autopkgtest environment for snapcraft's test suite — a one-line change to the ADT test configuration, approved by one reviewer and merged into master in Feb 2018.
stealth/space-bunny-alpha — closed resolved Merged #1907 (commit 570eaf8c9), correcting the ADT test environment with a one-line test configuration change.
qwen/qwen3.6-35b-a3b — — Merged a single-line fix to correctly configure the test environment for adt. Approved by a reviewer and merged by maintainer sergiusens after addressing an irrelevant error.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to set up the correct environment for adt tests. An irrelevant error was dismissed during review, and the fix was successfully integrated into the main branch.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1908 (confidence 82%)

    Immediate follow-up 'tests: update tests to work in adt' (commit a5c7d9e55), same day/series of ADT test-environment fixes.

  • Related To: canonical/snapcraft#1741 (confidence 55%)

    Earlier ADT test-infrastructure change ('adt on lxc requires squashfuse', commit 74474fb3b) in the same test-harness area.

Related issues

Issue Project State Summary Similarity
#1542511 Fix adt tests snapcraft (launchpad) closed ADT failures were fixed by merged ubuntu-core/snapcraft PR #305 (a99610b5a), adding Maven proxy configuration and noninteractive .deb installation.
75%
#1908 tests: update tests to work in adt snapcraft merged Merged PR #1908 in commit a5c7d9e55, adding Patchelf test support and a gotty build-snaps dependency so tests work in ADT.
74%