tests: update tests to work in adt
Metadata
Current evaluation
Merged PR #1908 in commit a5c7d9e55, adding Patchelf test support and a gotty build-snaps dependency so tests work in ADT.
Resolution: closed resolved
Reason: The approved PR was merged as a5c7d9e55. Reported ADT failures were identified as network flakes or timeouts, and the maintainer requested shipment.
Evaluated by: mr-cal-bot
No scores available.
Issue body
add patchelf_command attribute in SnapsTestCase and add the patchelf
and add the build-snaps dependency to gotty.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1908 in commit a5c7d9e55, adding Patchelf test support and a gotty build-snaps dependency so tests work in ADT. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1908 in a5c7d9e55, adding SnapsTestCase.patchelf_command, patchelf support, and a build-snaps dependency for gotty so tests run in ADT. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates tests for ADT by adding a patchelf_command attribute to SnapsTestCase and gotty dependencies. CI network and timeout flakiness in ROS tests were resolved by increasing timeouts. Approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after increasing CI timeouts to resolve network flakiness in ROS tests. Adds patchelf_command to SnapsTestCase and updates gotty dependencies to enable test execution in the ADT environment. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1907
(confidence 75%)
Merged PR #1907 immediately preceded this change and also updated the ADT test environment.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1907 tests: setup the correct environment for adt | snapcraft | merged | Merged PR #1907 (commit 570eaf8c9) fixing the ADT/autopkgtest environment for snapcraft's test suite — a one-line change to the ADT test configuration, approved by one reviewer and merged into master in Feb 2018. | |
| #1542511 Fix adt tests | snapcraft (launchpad) | closed | ADT failures were fixed by merged ubuntu-core/snapcraft PR #305 (a99610b5a), adding Maven proxy configuration and noninteractive .deb installation. |