← Back to issue list

schema: remove underscore from version pattern

View original Github issue

Metadata

Project
snapcraft
Number
#1933
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1933 (66fb3c411) removed underscores from the schema's version pattern, aligning validation with Snapcraft review-tool restrictions.

Resolution: closed resolved

Reason: PR #1933 was merged as commit 66fb3c411, updating schema validation to reject version strings containing underscores.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- An update from https://forum.snapcraft.io/t/3974, underscores should not be allowed in the version.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1933 (66fb3c411) removed underscores from the schema's version pattern, aligning validation with Snapcraft review-tool restrictions.
stealth/space-bunny-alpha — closed resolved Merged PR #1933 (commit 66fb3c411), removing underscores from the schema’s version pattern to align validation with Snapcraft review-tool restrictions.
qwen/qwen3.6-35b-a3b — — Merged changes remove underscores from the schema version pattern. Approved by a reviewer, passed CI, and aligns with forum discussions and existing tooling constraints.
qwen3.6-35b-a3b-mtp-q6 — — Merged schema changes removing underscores from the version pattern. The update aligns with community guidelines and existing review tool restrictions, ensuring consistent version formatting.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1924 schema: update version regex snapcraft merged Merged PR #1924 (commit 818eb0390) updated the schema version-validation regex to match snapd and the review tools.
79%