← Back to issue list

schema: update version regex

View original Github issue

Metadata

Project
snapcraft
Number
#1924
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged update to the schema version regex, aligning validation with snapd and review tools. Approved by three reviewers, passed CI checks, and modified two files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- In response to https://forum.snapcraft.io/t/3974, update Snapcraft to use the same pattern for version validation as snapd and the review tools.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update to the schema version regex, aligning validation with snapd and review tools. Approved by three reviewers, passed CI checks, and modified two files.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer kyrofa to align Snapcraft's schema version validation regex with snapd and review tools, addressing forum discussion #3974.
qwen3.6-35b-a3b-mtp-q6 Merged schema update replacing the version regex to align Snapcraft's validation with snapd and the review tools.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1957 schema: improve the snap name's validator snapcraft merged Merged schema validator improvements. Fixed exponential regex performance, added length validation, and clarified error messages. Approved by two reviewers, modified two files, and aligns with project-wide validation unification.
78%
#3303 schema: add regex to validate description is non-empty snapcraft merged Merged a schema update adding a regex pattern to validate non-empty snap descriptions. This catches metadata errors earlier in the build process. Approved by maintainer, passed CI checks, and integrated into the main branch.
76%
#1933 schema: remove underscore from version pattern snapcraft merged Merged changes remove underscores from the schema version pattern. Approved by a reviewer, passed CI, and aligns with forum discussions and existing tooling constraints.
75%
#2609 schema: allow 'snapd' snap type snapcraft merged Merged to allow the 'snapd' snap type in the schema. Approved by one reviewer, passed CI checks, and modified three files.
71%