← Back to issue list

schema: update version regex

View original Github issue

Metadata

Project
snapcraft
Number
#1924
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1924 (commit 818eb0390) updated the schema version-validation regex to match snapd and the review tools.

Resolution: closed resolved

Reason: The change was merged with maintainer approval in PR #1924, resolving to commit 818eb0390.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- In response to https://forum.snapcraft.io/t/3974, update Snapcraft to use the same pattern for version validation as snapd and the review tools.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1924 (commit 818eb0390) updated the schema version-validation regex to match snapd and the review tools.
stealth/space-bunny-alpha — closed resolved Merged PR #1924 (commit 818eb0390) updated the schema version regex to match validation in snapd and review tools.
qwen/qwen3.6-35b-a3b — — Merged update to the schema version regex, aligning validation with snapd and review tools. Approved by three reviewers, passed CI checks, and modified two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer kyrofa to align Snapcraft's schema version validation regex with snapd and review tools, addressing forum discussion #3974.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1933 schema: remove underscore from version pattern snapcraft merged Merged PR #1933 (66fb3c411) removed underscores from the schema's version pattern, aligning validation with Snapcraft review-tool restrictions.
79%
#1622 schema: sync patterns with snapd snapcraft merged Merged PR #1622 in commit 066d6e757, aligning snap and hook name schema patterns with snapd and improving jsonschema error handling; fixes LP #1693798.
71%