meta: make sure adapter does not propagate
Metadata
Current evaluation
Merged to prevent the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug #1750658. Approved by two reviewers, passed CI, and applied with 26 additions and 2 deletions across two files.
Suggested action: —
No scores available.
Issue body
adapter is a snapcraft.yaml only property and should not make it into
snap.yaml
LP: #1750658
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to prevent the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug #1750658. Approved by two reviewers, passed CI, and applied with 26 additions and 2 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug 1750658. Snapcraft-only metadata is now isolated during the build process. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to prevent the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug #1750658. The change isolates snapcraft-specific metadata during the build process. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2853 meta: do not set snapcraft-runner when adapter is "none" | snapcraft | merged | Merged fix ensuring snapcraft honors the 'none' adapter setting by omitting the snapcraft-runner command-chain. Previously, the runner was incorrectly injected regardless of adapter configuration. Approved and merged with accompanying spread tests. | |
| #2912 meta: do not prime commands with adapter == "none" | snapcraft | merged | Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes unit and spread test updates. Approved and passed CI. | |
| #1750658 snapcraft should filter out 'adapter' when generating snap.yaml | snapcraft (launchpad) | closed | Closed without resolution. Snapcraft continues to pass the adapter field to snap.yaml, where snapd ignores it. No fix was applied. |