meta: make sure adapter does not propagate
Metadata
Current evaluation
Merged PR #1955 fixed snap.yaml generation so the snapcraft.yaml-only apps.adapter field is not propagated, resolving LP #1750658.
Resolution: closed resolved
Reason: PR #1955 was merged as commit b93625a37 after approval by two reviewers. The change filters adapter from generated snap.yaml metadata and adds regression coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
adapter is a snapcraft.yaml only property and should not make it into
snap.yaml
LP: #1750658
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1955 fixed snap.yaml generation so the snapcraft.yaml-only apps.adapter field is not propagated, resolving LP #1750658. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1955 prevents the snapcraft.yaml-only apps.adapter field from propagating into snap.yaml, fixing Launchpad #1750658. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to prevent the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug #1750658. Approved by two reviewers, passed CI, and applied with 26 additions and 2 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug 1750658. Snapcraft-only metadata is now isolated during the build process. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1750658 snapcraft should filter out 'adapter' when generating snap.yaml | snapcraft (launchpad) | closed | Snapcraft no longer propagates apps.adapter into generated snap.yaml; fixed by merged PR #1955 in commit b93625a37. | |
| #2853 meta: do not set snapcraft-runner when adapter is "none" | snapcraft | merged | Merged PR #2853 fixed app metadata handling so adapter: none does not add snapcraft-runner to command-chain; full and legacy adapters still do (commit 9599497fb). |