meta: do not set snapcraft-runner when adapter is "none"
Metadata
Current evaluation
Merged fix ensuring snapcraft honors the 'none' adapter setting by omitting the snapcraft-runner command-chain. Previously, the runner was incorrectly injected regardless of adapter configuration. Approved and merged with accompanying spread tests.
Suggested action: —
No scores available.
Issue body
When adapter == "none", snapcraft should not modify the
command or command-chain. However snapcraft presently
ignores the adapter setting when it comes time to set
the command-chain.
Instead, honor when adapter is "none".
With these changes, given a snapcraft yaml:
```
<snipped>
apps:
adapter-none:
command: test-cmd
adapter: none
adapter-full:
command: test-cmd
adapter: full
adapter-legacy:
command: test-cmd
adapter: legacy
wrapped-default:
command: test-cmd --test "@"
<snipped>
```
Will now yield:
```
apps:
adapter-full:
command: test-cmd
command-chain:
- snap/command-chain/snapcraft-runner
adapter-legacy:
command: test-cmd
command-chain:
- snap/command-chain/snapcraft-runner
adapter-none:
command: test-cmd
wrapped-default:
command: command-wrapped-default.wrapper
command-chain:
- snap/command-chain/snapcraft-runner
```
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring snapcraft honors the 'none' adapter setting by omitting the snapcraft-runner command-chain. Previously, the runner was incorrectly injected regardless of adapter configuration. Approved and merged with accompanying spread tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring snapcraft omits the snapcraft-runner from command-chain when adapter is none. Includes spread test to verify correct configuration handling. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring snapcraft omits snapcraft-runner from command-chain when adapter is none. Previously ignored the setting. Includes added spread test. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2912 meta: do not prime commands with adapter == "none" | snapcraft | merged | Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes unit and spread test updates. Approved and passed CI. | |
| #1955 meta: make sure adapter does not propagate | snapcraft | merged | Merged to prevent the adapter property from propagating from snapcraft.yaml to snap.yaml, resolving Launchpad bug #1750658. Approved by two reviewers, passed CI, and applied with 26 additions and 2 deletions across two files. | |
| #2891 meta: always generate snapcraft-runner to workaround classic (#2889) | snapcraft | merged | Merged as #2889. Introduces an empty snapcraft-runner to the command-chain to fix incorrect PATH resolution for classic snap apps. Includes unit tests and configurable fixtures. Approved by reviewers and passed CI. |