← Back to issue list

snap: actually plug the completer in.

View original Github issue

Metadata

Project
snapcraft
Number
#1956
Type
pull request
State
merged
Author
chipaca
Labels
Created
Updated
Closed

Current evaluation

Merged to enable snapcraft's tab completer, resolving bug lp:1751391. Approved by a reviewer and merged despite pre-existing test failures on master.

Suggested action:

No scores available.

Issue body

snapcraft ships with a lovely tab completer, but it's not plugged in! This fixes that. Reported as [lp:1751391](https://bugs.launchpad.net/snapcraft/+bug/1751391). ----- - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh unit`? ----- The tests are failing for me on master, and they continue to fail in the same way with my change.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to enable snapcraft's tab completer, resolving bug lp:1751391. Approved by a reviewer and merged despite pre-existing test failures on master.
qwen3.6-35b-a3b-mtp-q6 Merged to enable snapcraft's missing tab completer, resolving launchpad bug 1751391. The fix was accepted and integrated despite pre-existing test failures on master.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to enable snapcraft's missing tab completer, resolving Launchpad bug 1751391. The change was accepted and merged despite pre-existing test failures on master.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1751391 snapcraft's snap's snap.yaml doesn't plug in the completer snapcraft (launchpad) closed Missing completer line in snapcraft.yaml caused tab-completion failure. The report was closed without comments or resolution, indicating it was abandoned.
77%
#1409 snap: remove completer entry snapcraft merged Merged a one-line change removing a completer entry from the snap YAML. This served as a temporary workaround for snapd 2.32 compatibility, with plans to revert once version 2.33 reaches Xenial. Approved by one reviewer.
72%
#61 a first pass at tab completion for the snap (hand-crafted) charmcraft merged Merged after approval by two reviewers. Implements hand-crafted tab completion for the snap, adding 105 lines across three files and resolving issue #59.
71%
#1570506 Snapcraft should use bash-completion snapcraft (launchpad) closed Snapcraft bash-completion integration was implemented and verified. Tab completion now functions for all snapcraft commands, resolving the missing shell integration with no regression risk.
70%