snap: actually plug the completer in.
Metadata
Current evaluation
PR #1956 merged as commit 32fbaf3d4, wiring the bundled completion.sh into snap metadata so Snapcraft exposes tab completion.
Resolution: closed resolved
Reason: The change was merged via canonical/snapcraft#1956 as commit 32fbaf3d4. It restores the completer declaration in the Snapcraft app metadata.
Evaluated by: mr-cal-bot
No scores available.
Issue body
snapcraft ships with a lovely tab completer, but it's not plugged in!
This fixes that. Reported as [lp:1751391](https://bugs.launchpad.net/snapcraft/+bug/1751391).
-----
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
-----
The tests are failing for me on master, and they continue to fail in the same way with my change.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1956 merged as commit 32fbaf3d4, wiring the bundled completion.sh into snap metadata so Snapcraft exposes tab completion. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1956 (commit 32fbaf3d4) connected snapcraft's existing tab completer, fixing LP:1751391. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to enable snapcraft's tab completer, resolving bug lp:1751391. Approved by a reviewer and merged despite pre-existing test failures on master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to enable snapcraft's missing tab completer, resolving launchpad bug 1751391. The fix was accepted and integrated despite pre-existing test failures on master. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/snapcraft#1409
(confidence 95%)
Earlier change db235805a removed the completer entry, creating the reported regression.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1590767 Support snap installed completion scripts | snapcraft (launchpad) | closed | Resolved by snapd 2.28 automatic completion integration and snapcraft completer wiring in merged PR #1956 (commit 32fbaf3d4). | |
| #1751391 snapcraft's snap's snap.yaml doesn't plug in the completer | snapcraft (launchpad) | closed | Snap completion was fixed by PR #1956 (commit 32fbaf3d4), adding completer: completion.sh to Snapcraft's snap app definition. | |
| #61 a first pass at tab completion for the snap (hand-crafted) | charmcraft | merged | Merged hand-crafted tab completion for the snap in #61, closing #59; merge 1964e8c3 contained implementation commit 59dff60d. | |
| #453 Add in bash completion | snapcraft | merged | Merged PR #453 via commit 6ea95fd50, adding a simple Bash completion script for Snapcraft commands. | |
| #1390 meta: bash completion support | snapcraft | merged | Merged PR #1390 added bash completion support for snapcraft and snapcraft metadata, landing as commit 2d01bc112. | |
| #59 tab completion in-snap | charmcraft | closed | Tab completion for the Charmcraft snap was added by merged PR #61 (commit 59dff60d; merge 1964e8c3). | |
| #1570506 Snapcraft should use bash-completion | snapcraft (launchpad) | closed | Added bash-completion support to snapcraft via merged upstream PR #453 (commit 6ea95fd50, changelog 16e1a9d76). Shipped in snapcraft 2.9 SRU to xenial; verified by elopio and released to -updates on 2016-05-30. | |
| #1646213 Code completion for *.snap on the cli is broken | snapcraft (launchpad) | closed | Fixed by merged canonical/snapcraft#933 (commit 5c41e4bc), which corrected Bash completion for .snap files containing multiple dots. | |
| #5218 feat: add improved bash completion script | snapcraft | merged | Merged in #5218 (commit 387202653), replacing the manually maintained Bash completion with a dynamically generated script that tracks current commands and options; shipped in Snapcraft 8.7. | |
| #872 Add some further bash-completion | snapcraft | merged | Merged PR #872 via commit 5876e15ba, adding Bash completion for help plugins, snap/tour directories, and .snap files for several commands. |