feat: add improved bash completion script
Metadata
Current evaluation
Merged in #5218 (commit 387202653), replacing the manually maintained Bash completion with a dynamically generated script that tracks current commands and options; shipped in Snapcraft 8.7.
Resolution: closed resolved
Reason: The PR was approved and merged as commit 387202653. Snapcraft 8.7 release notes confirm that the completion file is now generated dynamically, keeping Bash completion aligned with current commands and options.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
CRAFT-3873
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #5218 (commit 387202653), replacing the manually maintained Bash completion with a dynamically generated script that tracks current commands and options; shipped in Snapcraft 8.7. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcraft#5218 via commit 387202653, replacing legacy Bash completion with an improved script. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the improved bash completion script after three approvals and passing CI checks. The update modifies seven files, reducing 47 lines to 21. Reviewers validated the changes and recommended future implementation of part name autocompletion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the improved bash completion script for CRAFT-3873. The PR passed lint and test checks, and reviewer sergiusens confirmed it worked as a significant improvement. Future enhancements for part name autocompletion were suggested. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#5022
(confidence 99%)
The outdated Bash completion issue was resolved by PR #5218.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #453 Add in bash completion | snapcraft | merged | Merged PR #453 via commit 6ea95fd50, adding a simple Bash completion script for Snapcraft commands. | |
| #5022 Bash completion script is outdated | snapcraft | closed | Snapcraft 8.7 replaced the stale manual Bash completion with an automatically generated script tracking current commands and options in merged PR #5218 (387202653). | |
| #1390 meta: bash completion support | snapcraft | merged | Merged PR #1390 added bash completion support for snapcraft and snapcraft metadata, landing as commit 2d01bc112. | |
| #2111 feat: add improved bash completion script | charmcraft | merged | Merged charmcraft#2111 in commit d5a4b704, replacing Charmcraft’s legacy Bash completion with an improved script generated through craft-cli completion tooling. | |
| #86 feat: add bash completion script | imagecraft | merged | Merged into main as f568b9a, adding Bash completion generation for imagecraft via craft-cli; CRAFT-3878. | |
| #319 feat: bash auto-completion generation | craft-cli | merged | Merged feature adding generated Bash auto-completion; it closes canonical/craft-cli#211 via commit 4d41d7d. | |
| #872 Add some further bash-completion | snapcraft | merged | Merged PR #872 via commit 5876e15ba, adding Bash completion for help plugins, snap/tour directories, and .snap files for several commands. | |
| #4559 bash-completion: update and improve supported completion cases | snapcraft | closed | Completion work in canonical/snapcraft#4559 was closed as stale and superseded by canonical/craft-cli#319, merged in commit 4d41d7d with generated Bash completion. | |
| #1570506 Snapcraft should use bash-completion | snapcraft (launchpad) | closed | Added bash-completion support to snapcraft via merged upstream PR #453 (commit 6ea95fd50, changelog 16e1a9d76). Shipped in snapcraft 2.9 SRU to xenial; verified by elopio and released to -updates on 2016-05-30. | |
| #793 feat: add improved bash completion script | rockcraft | merged | Merged PR #793 as commit 380dd3c1, adding improved Bash tab completion for commands and options; documented in the Rockcraft 1.8 release notes. |