← Back to issue list

extractors: add support for common-id

View original Github issue

Metadata

Project
snapcraft
Number
#1960
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1960 in commit 37ad88866, adding extractor support for common-id and closing #1954 after prerequisite #1879.

Resolution: closed resolved

Reason: PR #1960 was merged as commit 37ad88866, adding common-id support to extractors and closing #1954. Its prerequisite, PR #1879, had merged as 75a919b2c.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Closes #1954 Requires #1879

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1960 in commit 37ad88866, adding extractor support for common-id and closing #1954 after prerequisite #1879.
stealth/space-bunny-alpha — closed resolved Merged PR #1960 (commit 37ad88866) added common-id support to the extractors, closing feature request #1954 after its prerequisite extractor refactor #1879 (75a919b2c) replaced desktop IDs with paths.
stealth/space-bunny-alpha — closed resolved Merged #1960 (commit 37ad88866), adding common-id support to extractors and closing #1954 after required prerequisite #1879.
qwen/qwen3.6-35b-a3b — — Merged pull request adding common-id support to extractors. Closes #1954 and requires #1879. Approved by one reviewer with passing CI checks. Changes span 8 files with 71 additions and 42 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Added common-id support to extractors. Merged after passing static and unit tests, resolving issue #1954 and depending on #1879.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#1954 (confidence 100%)

    PR #1960 explicitly closed the common-id implementation issue.

  • Related To: snapcraft#1879 (confidence 100%)

    Required prerequisite merged as commit 75a919b2c.

Related issues

Issue Project State Summary Similarity
#1954 Implement support for `common-id` snapcraft closed Implemented AppStream common-id support in merged PR #1960 via commit 37ad88866, following prerequisite extractor changes in #1879.
75%