← Back to issue list

tests: remove ProjectOptions dependency from integration suite

View original Github issue

Metadata

Project
snapcraft
Number
#1965
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1965, removing ProjectOptions from integration tests across 12 files (+90/-33) and closing test-architecture issue #1953.

Resolution: closed resolved

Reason: PR #1965 was approved and merged as commit d00e2af55, completing the test-architecture work tracked by #1953.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Closes #1953

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1965, removing ProjectOptions from integration tests across 12 files (+90/-33) and closing test-architecture issue #1953.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1965 (commit d00e2af55), removing ProjectOptions from integration tests across 12 files and closing #1953.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#1965 after approval, removing ProjectOptions from integration tests across 12 files (+90/-33 lines) and closing #1953.
qwen/qwen3.6-35b-a3b — — Merged changes removing the ProjectOptions dependency from the integration test suite, closing issue #1953. Approved by one reviewer, passed CI, and modified 12 files (+90/-33 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the ProjectOptions dependency from the integration test suite, resolving issue #1953.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1953 (confidence 100%)

    Test-architecture issue explicitly closed by PR #1965.

Related issues

Issue Project State Summary Similarity
#1953 Add in test architecture snapcraft closed 2018 test-architecture cleanup landed: merged PR #1965 "tests: remove ProjectOptions dependency from integration suite" (+90/-33 across 12 files) removed the `from snapcraft import ProjectOptions` import; maintainer closed #1953 on 2018-03-03.
80%
#1972 tests: remove _options dependency from integration suite snapcraft merged Merged PR snapcraft#1972 (commit b250e330a) by maintainer come-maiz, dropping the last _options import from the integration test suite; follow-up to #1965 which had missed it.
77%
#1971 tests: remove dependency of internal repo from integration suite snapcraft merged Merged PR #1971 as commit fd92779bd, removing the integration suite's dependency on an internal repository and closing issue #1973.
77%