tests: remove _options dependency from integration suite
Metadata
Current evaluation
Merged PR snapcraft#1972 (commit b250e330a) by maintainer come-maiz, dropping the last _options import from the integration test suite; follow-up to #1965 which had missed it.
Resolution: closed resolved
Reason: The PR itself was merged into snapcraft as commit b250e330a, removing the remaining _options dependency from integration tests (1 file, +1/-4) and contributing to the test-architecture cleanup tracked in #1953.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Closes #1953
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR snapcraft#1972 (commit b250e330a) by maintainer come-maiz, dropping the last _options import from the integration test suite; follow-up to #1965 which had missed it. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1972 in commit b250e330a, removing the remaining _options dependency from the integration suite. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged, removing the _options dependency from the integration test suite and closing issue #1953. The commit initially omitted the Closes: keyword but was approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged, removing the _options dependency from the integration test suite and closing issue #1953. Commit message formatting was updated per reviewer feedback. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1965
(confidence 95%)
Earlier merged PR that removed the ProjectOptions dependency from the integration suite; this PR cleaned up a leftover _options reference it missed.
-
Related To:
canonical/snapcraft#1953
(confidence 90%)
Tracking issue 'Add in test architecture' that this PR and #1965 were working towards.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. | |
| #1965 tests: remove ProjectOptions dependency from integration suite | snapcraft | merged | Merged PR #1965, removing ProjectOptions from integration tests across 12 files (+90/-33) and closing test-architecture issue #1953. | |
| #1953 Add in test architecture | snapcraft | closed | 2018 test-architecture cleanup landed: merged PR #1965 "tests: remove ProjectOptions dependency from integration suite" (+90/-33 across 12 files) removed the `from snapcraft import ProjectOptions` import; maintainer closed #1953 on 2018-03-03. | |
| #1971 tests: remove dependency of internal repo from integration suite | snapcraft | merged | Merged PR #1971 as commit fd92779bd, removing the integration suite's dependency on an internal repository and closing issue #1973. |