python plugin: find setup.py when source-subdir is used
Metadata
Current evaluation
Merged in PR #1975 as commit 0dbc20658, fixing Python plugin setup.py discovery to honor source-subdir for LP bug #1752481.
Resolution: closed resolved
Reason: PR #1975 was merged as commit 0dbc20658. The change makes the Python plugin find setup.py within the configured source-subdir, resolving LP bug #1752481.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1752481
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #1975 as commit 0dbc20658, fixing Python plugin setup.py discovery to honor source-subdir for LP bug #1752481. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 0dbc20658: Python plugin setup.py discovery now honors source-subdir, addressing LP #1752481. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcraft#1975 as commit 0dbc20658, fixing Python plugin setup.py discovery to honor source-subdir for LP bug #1752481. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a Python plugin fix to locate setup.py when source-subdir is used, resolving LP #1752481. Reviewers approved but flagged architectural concerns about sourcedir versus builddir. The patch will be backported to outside consumers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a Python plugin fix to locate setup.py with source-subdir. Reviewers flagged a broader builddir versus sourcedir architectural issue, but the change was accepted. Author specified it targets an external consumer branch, not master. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1741131 python plugin ignores source-subdir | snapcraft (launchpad) | open | Python plugin setup.py discovery now honors source-subdir; snapcraft PR #1975 fixed the bug in commit 0dbc20658, but this Launchpad report remains open. | |
| #751 python3 plugin: run setup.py in source subdir if such option exists | snapcraft | closed | Closed unmerged as superseded by canonical/snapcraft#771, merged as commit bb7bd40e1 with Python plugin improvements fixing setup.py handling for source-subdir. |