python plugin: find setup.py when source-subdir is used
Metadata
Current evaluation
Merged a Python plugin fix to locate setup.py when source-subdir is used, resolving LP #1752481. Reviewers approved but flagged architectural concerns about sourcedir versus builddir. The patch will be backported to outside consumers.
Suggested action: —
No scores available.
Issue body
LP: #1752481
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a Python plugin fix to locate setup.py when source-subdir is used, resolving LP #1752481. Reviewers approved but flagged architectural concerns about sourcedir versus builddir. The patch will be backported to outside consumers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a Python plugin fix to locate setup.py with source-subdir. Reviewers flagged a broader builddir versus sourcedir architectural issue, but the change was accepted. Author specified it targets an external consumer branch, not master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to fix setup.py discovery when source-subdir is used in the Python plugin. Reviewers noted a broader builddir versus sourcedir issue for the base plugin. Applied as a targeted fix for external consumers. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1741131 python plugin ignores source-subdir | snapcraft (launchpad) | open | Python plugin can't find setup.py when it lives in a source-subdir, so it finishes without installing anything. No comments; a fix to locate setup.py under source-subdir was merged in PR #1975 (earlier #771 superseded #751). | |
| #751 python3 plugin: run setup.py in source subdir if such option exists | snapcraft | closed | Patch to run setup.py in a specified source subdirectory was closed without merging. It was superseded and resolved by fix #771. |