← Back to issue list

python3 plugin: run setup.py in source subdir if such option exists

View original Github issue

Metadata

Project
snapcraft
Number
#751
Type
pull request
State
closed
Author
yphus
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as superseded by canonical/snapcraft#771, merged as commit bb7bd40e1 with Python plugin improvements fixing setup.py handling for source-subdir.

Resolution: closed superseded

Reason: The maintainer closed #751 with the comment that it had been fixed in #771. PR #771 was merged into main as commit bb7bd40e1.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Projects such as lp:checkbox contains various python3 sub-projects in different subfolders. Unfortunately the python3 plugin does not run setup.py from there but instead from the root folder, not honoring the source subdir option. This little patch ensures that setup.py will be run from the specified subdir. Sylvain Pineau (https://launchpad.net/~sylvain-pineau)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by canonical/snapcraft#771, merged as commit bb7bd40e1 with Python plugin improvements fixing setup.py handling for source-subdir.
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by snapcraft/snapcraft#771, which fixed Python plugin source-subdir handling in commit bb7bd40e1.
qwen/qwen3.6-35b-a3b — — Patch to run setup.py in a specified source subdirectory was closed without merging. It was superseded and resolved by fix #771.
qwen3.6-35b-a3b-mtp-q6 — — Closed as it was already fixed in pull request #771. The change ensures the python3 plugin runs setup.py in the specified source subdirectory instead of the root.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#771 (confidence 100%)

    The maintainer explicitly cited #771 as the resolving change; it merged as bb7bd40e1.

Related issues

Issue Project State Summary Similarity
#1741131 python plugin ignores source-subdir snapcraft (launchpad) open Python plugin setup.py discovery now honors source-subdir; snapcraft PR #1975 fixed the bug in commit 0dbc20658, but this Launchpad report remains open.
77%
#1975 python plugin: find setup.py when source-subdir is used snapcraft merged Merged in PR #1975 as commit 0dbc20658, fixing Python plugin setup.py discovery to honor source-subdir for LP bug #1752481.
74%