← Back to issue list

python3 plugin: run setup.py in source subdir if such option exists

View original Github issue

Metadata

Project
snapcraft
Number
#751
Type
pull request
State
closed
Author
yphus
Labels
Created
Updated
Closed

Current evaluation

Patch to run setup.py in a specified source subdirectory was closed without merging. It was superseded and resolved by fix #771.

Suggested action:

No scores available.

Issue body

Projects such as lp:checkbox contains various python3 sub-projects in different subfolders. Unfortunately the python3 plugin does not run setup.py from there but instead from the root folder, not honoring the source subdir option. This little patch ensures that setup.py will be run from the specified subdir. Sylvain Pineau (https://launchpad.net/~sylvain-pineau)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Patch to run setup.py in a specified source subdirectory was closed without merging. It was superseded and resolved by fix #771.
qwen3.6-35b-a3b-mtp-q6 Closed as it was already fixed in pull request #771. The change ensures the python3 plugin runs setup.py in the specified source subdirectory instead of the root.
qwen3.6-35b-a3b-mtp-q6 Superseded by fix in pull request #771. The patch aimed to ensure the python3 plugin runs setup.py from a specified source directory.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1975 python plugin: find setup.py when source-subdir is used snapcraft merged Merged a Python plugin fix to locate setup.py when source-subdir is used, resolving LP #1752481. Reviewers approved but flagged architectural concerns about sourcedir versus builddir. The patch will be backported to outside consumers.
79%
#1741131 python plugin ignores source-subdir snapcraft (launchpad) open Python plugin can't find setup.py when it lives in a source-subdir, so it finishes without installing anything. No comments; a fix to locate setup.py under source-subdir was merged in PR #1975 (earlier #771 superseded #751).
78%