← Back to issue list

lifecycle: when priming dependencies need to be primed

View original Github issue

Metadata

Project
snapcraft
Number
#1977
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1977 in commit 90557f016, forcing dependencies to be primed because the DT_NEEDED crawler needs them available.

Resolution: closed resolved

Reason: PR #1977 was merged with approval as commit 90557f016. Its lifecycle changes ensure dependencies are primed for DT_NEEDED dependency crawling, addressing LP #1752481.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add logic to force priming of dependencies as those are needed for the DT_NEEDED crawler. LP: #1752481 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1977 in commit 90557f016, forcing dependencies to be primed because the DT_NEEDED crawler needs them available.
stealth/space-bunny-alpha — closed resolved Merged #1977 as commit 90557f016, adding lifecycle logic to force dependency priming when required by the DT_NEEDED crawler; addresses LP #1752481.
qwen/qwen3.6-35b-a3b — — Merged logic to force priming of dependencies for the DT_NEEDED crawler, resolving LP #1752481. Approved by one reviewer, passed CI checks, and merged with 29 additions and 12 deletions across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged to force dependency priming for the DT_NEEDED crawler. Author sergiusens addressed test failures flagged by reviewer kyrofa, and the changes were successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2040 lifecycle: always prime dependencies snapcraft closed PR #2040 was closed unmerged after a reviewer requested related lifecycle-logic changes; no resolving commit or superseding work was recorded.
73%
#1290 Unnecessary priming of dependency when priming a part craft-parts open Triaged bug report reproduces dependency foo being primed when bar is primed; current code still maps Step.PRIME to Step.PRIME, while a maintainer questions whether dependencies must be primed.
70%