← Back to issue list

lifecycle: always prime dependencies

View original Github issue

Metadata

Project
snapcraft
Number
#2040
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #2040 was closed unmerged after a reviewer requested related lifecycle-logic changes; no resolving commit or superseding work was recorded.

Resolution: closed stale

Reason: On 2018-03-28, reviewer kyrofa noted that additional lifecycle logic needed adjustment and offered to bring in a follow-up. The PR was never merged, and no maintainer closure explanation or resolving commit was recorded.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This ensures consistency across build variations of classic, libc6 patching and strict. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #2040 was closed unmerged after a reviewer requested related lifecycle-logic changes; no resolving commit or superseding work was recorded.
stealth/space-bunny-alpha — closed stale Closed unmerged after requested lifecycle follow-up; no resolving commit or maintainer rationale for closure is recorded.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of follow-up #1977, whose commit 90557f016 fixed dependency priming in lifecycle builds.
qwen/qwen3.6-35b-a3b — — Closed and superseded. The dependency priming change required additional lifecycle logic adjustments. Follow-up modifications were addressed separately by another maintainer.
qwen3.6-35b-a3b-mtp-q6 — — Merged after reviewer noted follow-up adjustments to related lifecycle logic were required.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3576 [WIP] lifecycle: only consider pull dependencies for v1 snapcraft closed PR #3576 was closed unmerged; the WIP change limiting pull dependencies to lifecycle v1 received no reviews or CI and was abandoned after more than 130 days of inactivity.
74%
#1977 lifecycle: when priming dependencies need to be primed snapcraft merged Merged PR #1977 in commit 90557f016, forcing dependencies to be primed because the DT_NEEDED crawler needs them available.
73%
#1626 lifecycle: split into its own package snapcraft merged Merged PR #1626 as commit 5aab678b8, splitting the lifecycle module into its own package to separate concerns and improve navigability.
71%