← Back to issue list

Fix ordering for conditional negations in catkin tests

View original Github issue

Metadata

Project
snapcraft
Number
#199
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #199 by sergiusens, a two-line test fix in the catkin plugin tests changing "if not ... in ..." to "if ... not in ..."; come-maiz approved and merged it immediately on 2016-01-05.

Resolution: closed resolved

Reason: The pull request itself was merged (title: Fix ordering for conditional negations in catkin tests), with come-maiz commenting "Trivial, so merging at once." The two-line change landed on master; PR #292 later backported it to the 1.x branch.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The configtional is `if not ... in ...` when it should be `if ... not in ...`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #199 by sergiusens, a two-line test fix in the catkin plugin tests changing "if not ... in ..." to "if ... not in ..."; come-maiz approved and merged it immediately on 2016-01-05.
stealth/space-bunny-alpha — closed resolved Merged a two-line catkin-test fix, correcting conditional negation order from "if not ... in ..." to "if ... not in ...".
qwen/qwen3.6-35b-a3b — — Merged a trivial fix correcting Python conditional negation syntax in catkin tests from if not ... in ... to if ... not in .... Approved and merged immediately following a single positive review.
qwen3.6-35b-a3b-mtp-q6 — — Merged a trivial fix correcting Python conditional syntax in catkin tests. Replaced invalid if not ... in ... with the proper if ... not in ... structure. Approved and merged immediately by a maintainer.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#292 (confidence 85%)

    Backport to 1.x of this same catkin test fix, merged separately.

Related issues

Issue Project State Summary Similarity
#292 Backport to 1.x: Fix ordering for conditional negations in catkin tests snapcraft merged Merged into snapcraft 1.x via PR #292, backporting PR #199’s two-line fix for conditional-negation ordering in catkin tests.
74%