← Back to issue list

Backport to 1.x: Fix ordering for conditional negations in catkin tests

View original Github issue

Metadata

Project
snapcraft
Number
#292
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as a backport of #199 to the 1.x branch. Resolves an ordering issue with conditional negations in catkin tests. Approved by @sergiusens and verified after retriggering example tests.

Suggested action: —

No scores available.

Issue body

Backport of #199 for 1.x

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged as a backport of #199 to the 1.x branch. Resolves an ordering issue with conditional negations in catkin tests. Approved by @sergiusens and verified after retriggering example tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #199 to the 1.x branch. Corrects ordering for conditional negations in catkin tests. Approved and verified after test retrigger.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #199 to the 1.x branch, resolving conditional negation ordering issues in catkin tests. Approved and validated by @sergiusens prior to integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#219 Backport to 1.x: Replace use of `assert_not_called` in the catkin tests snapcraft merged Merged PR #200 backport to the 1.x branch, replacing assert_not_called calls in catkin tests. The change updated one file with six additions and three deletions, successfully applying the test fix to the legacy release line.
77%
#199 Fix ordering for conditional negations in catkin tests snapcraft merged Merged a trivial fix correcting Python conditional negation syntax in catkin tests from if not ... in ... to if ... not in .... Approved and merged immediately following a single positive review.
76%
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged Merged a backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The update modified two files with a net change of -3 lines.
72%
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged Merged backport of PR #175 to the 1.x branch, refactoring the Catkin plugin build across three files. Changes applied directly without reviewer comments or CI checks.
70%