Backport to 1.x: Fix ordering for conditional negations in catkin tests
Metadata
Current evaluation
Merged into snapcraft 1.x via PR #292, backporting PR #199’s two-line fix for conditional-negation ordering in catkin tests.
Resolution: closed resolved
Reason: PR #292 was merged into the 1.x branch with the ordering correction from PR #199. Maintainer @sergiusens approved the backport and reran the example tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Backport of #199 for 1.x
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into snapcraft 1.x via PR #292, backporting PR #199’s two-line fix for conditional-negation ordering in catkin tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into 1.x, backporting #199 to correct conditional-negation ordering in catkin tests; @sergiusens approved and example tests were retriggered. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged as a backport of #199 to the 1.x branch. Resolves an ordering issue with conditional negations in catkin tests. Approved by @sergiusens and verified after retriggering example tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged backport of PR #199 to the 1.x branch. Corrects ordering for conditional negations in catkin tests. Approved and verified after test retrigger. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#199
(confidence 100%)
Original merged fix backported to the 1.x branch by PR #292.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #181 Backport to 1.x: Resolve FIXME in Catkin plugin | snapcraft | merged | PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297. | |
| #219 Backport to 1.x: Replace use of `assert_not_called` in the catkin tests | snapcraft | merged | Merged into 1.x as PR #219, backporting #200 to replace assert_not_called() with assertFalse(mock.called) in catkin tests while preserving custom failure messages. | |
| #199 Fix ordering for conditional negations in catkin tests | snapcraft | merged | Merged PR #199 by sergiusens, a two-line test fix in the catkin plugin tests changing "if not ... in ..." to "if ... not in ..."; come-maiz approved and merged it immediately on 2016-01-05. | |
| #184 Backport to 1.x: Catkin plugin: Refactor build. | snapcraft | merged | PR #184 merged into 1.x, backporting #175’s Catkin build refactor to simplify build logic and dependency handling. |