← Back to issue list

docker: add the architecture

View original Github issue

Metadata

Project
snapcraft
Number
#1994
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged snapcraft#1994 in commit 54d7494f8, setting SNAP_ARCH for Docker images and making a missing value fail explicitly.

Resolution: closed resolved

Reason: The Docker changes were merged via snapcraft#1994 at commit 54d7494f8, configuring the correct SNAP_ARCH and adding an explicit error when it is absent.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Setup the correct SNAP_ARCH for our docker images, also blow up in a more obvious way if it is missing. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcraft#1994 in commit 54d7494f8, setting SNAP_ARCH for Docker images and making a missing value fail explicitly.
stealth/space-bunny-alpha — closed resolved Merged in #1994 via commit 54d7494f8, exporting SNAP_ARCH for Docker images and failing explicitly when it is unset.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#1994 as commit 54d7494f8, configuring SNAP_ARCH for Docker images and failing explicitly when it is missing.
qwen/qwen3.6-35b-a3b — — Configured SNAP_ARCH for Docker images and added explicit failure if missing. Merged following successful CI checks and two reviewer approvals.
qwen3.6-35b-a3b-mtp-q6 — — Configures SNAP_ARCH for Docker images and adds explicit error handling when the architecture is missing. Merged after maintainer approval.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2592 docker/bin/snapcraft-wrapper: use dpkg for architecture snapcraft closed PR #2592 was closed unmerged after its requested dpkg-based architecture change remained unfinished; the author questioned whether overriding SNAP_ARCH made it unnecessary.
74%