docker/bin/snapcraft-wrapper: use dpkg for architecture
Metadata
Current evaluation
PR #2592 was closed unmerged after its requested dpkg-based architecture change remained unfinished; the author questioned whether overriding SNAP_ARCH made it unnecessary.
Resolution: closed stale
Reason: Maintainer @sergiusens closed it on 2019-06-24 with “Feel free to propose once you have time to do so,” while review remained changes_requested with one unresolved comment. No resolving commit or merge was recorded.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This allows the wrapper to be used for architectures other than amd64 on
docker builds without modification.
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #2592 was closed unmerged after its requested dpkg-based architecture change remained unfinished; the author questioned whether overriding SNAP_ARCH made it unnecessary. | |
| stealth/space-bunny-alpha | — | closed stale | PR #2592 was closed unmerged after the requested dpkg-based architecture change went unfinished; its author questioned whether overriding Dockerfile's SNAP_ARCH would make it unnecessary. | |
| stealth/space-bunny-alpha | — | closed stale | Architecture detection using dpkg was abandoned unmerged: a maintainer closed #2592 for inactivity, and the author later questioned whether overriding SNAP_ARCH made the change unnecessary. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The author abandoned the change after determining it may be unnecessary if the SNAP_ARCH variable can be overridden directly in the Dockerfile. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The author abandoned the PR after realizing overriding SNAP_ARCH in the Dockerfile might make the changes unnecessary. Maintainer closed it pending a future re-propose if needed. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1994
(confidence 90%)
Commit 54d7494f8 exported SNAP_ARCH in Docker builds, prompting the author to question whether this change was still needed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #314 Replace dpkg-architecure calls in tests | snapcraft | merged | PR #314 (sergiusens) merged, replacing tests' direct dpkg-architecture invocations with Snapcraft architecture helpers so the dependency is captured in snapcraft.yaml. Fixes LP bug #1544340. | |
| #1994 docker: add the architecture | snapcraft | merged | Merged snapcraft#1994 in commit 54d7494f8, setting SNAP_ARCH for Docker images and making a missing value fail explicitly. | |
| #4289 dpkg --add-architecture fails when using package-repositories | snapcraft | closed | Fixed in craft-archives 1.1.3 via canonical/craft-archives#96 (06b1ca2), reordering dpkg options so --root precedes --add-architecture; rolled out via Snapcraft candidate. | |
| #1698888 Snapcraft dpkg-query error on multiarch OS | snapcraft (launchpad) | open | The 2017 multiarch `dpkg -L libc6` build failure was acknowledged, but the affected legacy code has since disappeared; current Snapcraft no longer contains that call. | |
| #2671 docker: remove snapcraft-wrapper | snapcraft | merged | PR #2671 merged as commit 393956c09, deleting the now-obsolete docker/bin/snapcraft-wrapper left over after #2591 (b292b64d). Maintainers noted it broke the gnome-3-28-1804 image, to be fixed separately. |