Replace use of `assert_not_called` in the catkin tests
Metadata
Current evaluation
Merged PR #200 via commit 9c5b83418 (change 50b9537ce): replaced assert_not_called with assertFalse(mock.called) in catkin tests to preserve custom failure messages.
Resolution: closed resolved
Reason: PR #200 was merged into the mainline at commit 9c5b83418 (change 50b9537ce), swapping assert_not_called for assertFalse(mock.called) in the catkin tests so mock assertions keep their descriptive message. Maintainer @kyrofa approved the change.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Mocks using `assert_not_called` don't take a message, to keep the message
we use `assertFalse` and the `called` attribute of the mock.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #200 via commit 9c5b83418 (change 50b9537ce): replaced assert_not_called with assertFalse(mock.called) in catkin tests to preserve custom failure messages. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #200 via commit 9c5b83418 (change 50b9537ce), replacing assert_not_called with assertFalse(mock.called) to preserve custom failure messages in catkin tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#200, replacing assert_not_called with assertFalse(mock.called) in catkin tests to preserve custom failure messages; later backported by merged #219. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a change replacing assert_not_called with assertFalse and the mock called attribute in catkin tests to preserve custom error messages. Approved by @kyrofa and merged after CI passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaced assert_not_called with assertFalse and the mock called attribute in catkin tests to preserve custom error messages. Approved by @kyrofa after CI passed. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #219 Backport to 1.x: Replace use of `assert_not_called` in the catkin tests | snapcraft | merged | Merged into 1.x as PR #219, backporting #200 to replace assert_not_called() with assertFalse(mock.called) in catkin tests while preserving custom failure messages. |